Comments on descriptions in chapter 1
Issue #3
resolved
- Incompressible flows are described as $\partial \rho/\partial t = 0$, but there are variable-density incompressible flows (e.g. used for incompressible Rayleigh-Taylor simulations). I think a more common definition is $D\rho/Dt = 0$ which means the density of a fluid element doesn’t change along streamlines (no compressibility effects).
- In the energy conservation section, it is written h = c_p T, but this assumes that the specific heat is constant in temperature (not true for a general equation of state).
- You should also note that you are assuming that the thermal conductivity, k, is constant
- In the “Discretization of the Generic Conservation Equation” section, you write x as three-dimensional, but then talk about one-way and two-way, which are one-dimensional concepts. Somewhere it should be said that you are now working in 1-d
- “descretized” is misspelled in the “Source Term” section
Comments (7)
-
-
In the Transient Term section, you miss $dt$ for the integration with respect to time
-
In Advection Term the variable $A_{ip}$ is first introduce with no explanation
-
In the Linearization, is $P$ the control volume or $V_p$?
-
repo owner Regarding the issues raised by Michael Zingale:
- In this case, the special case that I wanted to refer to was constant density flow. You are absolutely right in your definition. I’ve updated the notebook to clarify that I am talking about constant density flows.
- I’ve clarified that this is only for the case of constant specific heat capacities.
- This is noted in brackets where it is stated that the thermophysical properties are constant.
- I’ve clarified that this discussion is referring to a 1d example.
- Fixed this.
-
repo owner I’ve also addressed the issues of Sidafa Conde, except for the last one. The answer is that $P$ denotes the control volume and $V_P$ denotes its volume. Please open another issue if you think this should be further clarified.
-
repo owner - changed status to resolved
- Log in to comment
spelling mistake: “negnigible” → negligible