Falagard-Properties-Branch ready for merge

Issue #708 resolved
Former user created an issue

Automatic migration. Original reporter: "Hanmac"

i make a branch for adding get,set and Iterator functions to the files of LooknFeel. and PropertyDefinitions are know templated.

link: https://bitbucket.org/Hanmac/cegui/changesets/tip/branch%28%22falagard-properties-devel%22%29

Reproducibility: N/A

Comments (3)

  1. Former user Account Deleted

    Original reporter: Hanmac

    i mean i add the methods to the classes so they can be used for an LooknFeel-Editor

  2. Paul Turner

    Adding a note to record the current situation: Have reviewed the code and discussed some issues with Hanmac, the three outstanding things that block merging these changes are:

    1) NamedArea::setName and ImagerySection::setName do not update the key name used in the containing collection in WidgetLookFeel. Suggested setting the name via 'rename' functions on WidgetLookFeel.

    2) getValue() overloads added to some dimension types might cause confusion, so these can be renamed to getBaseValue() (and the associated setter changed to setBaseValue()).

    3) I'm 90% sure that the fact WidgetLookFeel::addPropertyDefinition and WidgetLookFeel::addPropertyLinkDefinition do not clone the object passed will cause a memory leak. Solution would simply be to delete the objects in the collection when the WidgetLookFeel is destroyed.

  3. Log in to comment