1. Python CFFI
  2. Untitled project
  3. cffi
  4. Pull requests

Pull requests

#65 Merged
Repository
mattip
Branch
default
Repository
cffi
Branch
default

remove _hack_at_distutils which imports setuptools on win32, it has too many side effects.

Author
  1. mattip
Reviewers
Description

Not needed since 1.0 since developers can distribute binary packages, even on win32

Comments (1)

  1. Armin Rigo

    How about adding a corresponding comment in the docs in the Windows section? We could say that there is a known problem with distutils on Python 2.7.9, as explained in https://bugs.python.org/issue23246, and the same problem applies whenever you want to run a compile(). We could also mention that "import setuptools" might help. (EDIT: any 2.7.x with x >= 9, actually. It seems that the bug report was closed as "not a bug" and they won't fix it. I don't even want to understand why.)

    Also, maybe keep the hack when we call verify(), for backward compatibility. Otherwise, existing old code using ffi.verify() will suddenly fail with newer cffi.