Sam Adams avatar Sam Adams committed 44277a6

Fix checkstyle errors, and add suppression to workaround a bug

Comments (0)

Files changed (4)

chempound-webapp/src/checkstyle/suppressions.xml

+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Puppy Crawl//DTD Suppressions 1.1//EN"
+        "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
+<suppressions>
+    <!-- Workaround checkstyle bug with custom exceptions -->
+    <suppress files="src/main/java/net/chempound/webapp/pingback/PingbackService\.java" checks="RedundantThrowsCheck" />
+    <suppress files="src/main/java/net/chempound/webapp/pingback/PingbackResource\.java" checks="RedundantThrowsCheck" />
+</suppressions>

chempound-webapp/src/main/java/net/chempound/webapp/content/ResourceMapResource.java

 import org.restlet.data.MediaType;
 import org.restlet.data.Reference;
 import org.restlet.data.Status;
-import org.restlet.engine.http.header.HeaderConstants;
 import org.restlet.ext.json.JsonRepresentation;
 import org.restlet.representation.Representation;
 import org.restlet.representation.Variant;

chempound-webapp/src/main/java/net/chempound/webapp/pingback/PingbackFault.java

     ALREADY_REGISTERED(48, "The pingback has already been registered."),
     ACCESS_DENIED(49, "Access denied."),
     COMMUNICATION_ERROR(50, "The server could not communicate with an upstream server, or received an error from an " +
-                             "upstream server, and therefore could not complete the request.")
-    ;
+                             "upstream server, and therefore could not complete the request.");
 
     private final int code;
     private final String message;

chempound-webapp/src/main/java/net/chempound/webapp/pingback/XmlRpcFault.java

     SERVER_ERROR_INTERNAL_XMLRPC_ERROR(-32603, "Server error: internal xml-rpc error."),
     APPLICATION_ERROR(-32500, "Application error."),
     SYSTEM_ERROR(-32400, "System error."),
-    TRANSPORT_ERROR(-32300, "Transport error.")
-    ;
+    TRANSPORT_ERROR(-32300, "Transport error.");
 
     private final int code;
     private final String message;
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.