Robert Brewer avatar Robert Brewer committed 016f208

SignalHandler.unsubscribe now warns if our handler is not returned. See #826.

Comments (0)

Files changed (1)

cherrypy/process/plugins.py

                 self.bus.log("Restoring %s handler %r." % (signame, handler))
             
             try:
-                _signal.signal(signum, handler)
+                our_handler = _signal.signal(signum, handler)
+                if our_handler is None:
+                    self.bus.log("Restored old %s handler %r, but our "
+                                 "handler was not registered." %
+                                 (signame, handler), level=30)
             except ValueError:
                 self.bus.log("Unable to restore %s handler %r." %
-                             (signame, handler), traceback=True)
+                             (signame, handler), level=40, traceback=True)
     
     def set_handler(self, signal, listener=None):
         """Subscribe a handler for the given signal (number or name).
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.