Issue #1089 resolved

no logging of internal errors in server

Anonymous created an issue

the WSGIServer will attempt to report internal server errors to the client. However, if the client isn't listening, there is no recourse to log these errors somewhere else. Perhaps it would be wise to reraise them? The code in question is this (cherrypy.wsgiserver.init.py, lines 1289: {{{ elif errnum not in socket_errors_to_ignore: if req and not req.sent_headers: try: req.simple_response("500 Internal Server Error", format_exc()) except FatalSSLAlert: # Close the connection. return }}} and later {{{ except Exception: if req and not req.sent_headers: try: req.simple_response("500 Internal Server Error", format_exc()) except FatalSSLAlert: # Close the connection. return }}}

So, an error that can't be delivered to the client will be silently ignored. Errors that occur in sending the error to the client do get raised out of the function, but they trample the original error, of course.

Reported by kristjan@ccpgames.com

Comments (2)

  1. Log in to comment