Issue #871 resolved

Turn off ipv6only on systems where it is on by default

Anonymous created an issue

Systems vary in their treatment of the IPV6_V6ONLY option; the RFC says it should be on by default (apparently, only Linux deviates). For CherryPy, I propose that it is more useful if the default is off, when the user specifies :: as the bind_address - this supposedly means "all incoming connections". The attached patch makes sure the option is disabled on systems that have the option in the first place.

Reported by martin@v.loewis.de

Comments (6)

  1. Anonymous

    You have applied the patch at the wrong level. Manipulating the IPV6 stack should happen regardless of whether or not one has passed in SSL certificate files. Martin's patch was doing that at the same level as self.socket.bind(), while now it is done with an additional indent.

  2. Log in to comment