Pull requests

#15 Merged
Repository
stpierre stpierre
Branch
1001-client-cert-verify
Repository
cherrypy cherrypy
Branch
default

Added support for client certificate verification in SSLAdapter (issue #1001)

Author
  1. Chris St. Pierre
Reviewers
Description

I've ported the last patch submitted against issue #1001 to the latest code. The tests provided with that patch succeed.

Comments (2)

  1. Joseph Tate

    I'm having difficulty getting the new tests to pass;

    First off, I'm getting an error on "test_checked (cherrypy.test.test_ssl.SSLClientCertTest_{'regular_fail': False, 'server_check_host': False, 'checked_fail': False, 'server_ssl': 'builtin', 'client_host': '127.0.0.1', 'server_check': 'optional', 'server_host': '0.0.0.0', 'client_cert': '/home/jtate/devel/cherrypy/cherrypy-bitbucket/cherrypy/test/client_wrong_host.cert'})". A URLError gets raised. Nothing is listening on port 8080.

    Then when running another test, it kills the whole test suite:

    ...
    "test_checked (cherrypy.test.test_ssl.SSLClientCertTest_{'regular_fail': False, 'server_check_host': False, 'checked_fail': False, 'server_ssl': 'pyopenssl', 'client_host': '127.0.0.1', 'server_check': 'optional', 'server_host': '0.0.0.0', 'client_cert': '/home/jtate/devel/cherrypy/cherrypy-bitbucket/cherrypy/test/client_wrong_host.cert'}) ... 
    (cherrypy-py27) [03/18 15:59:21] jtate@laputa(0):~/devel/cherrypy/cherrypy-bitbucket[66]$ echo $?
    70
    

    I haven't tried it with Python 3.3 yet.