1. cherrypy
  2. CherryPy
  3. Pull requests

Pull requests

#23 Declined
Repository
bcwalrus
Branch
default
Repository
cherrypy
Branch
default

Add better error message on bind failure

Author
  1. bc Wong
Reviewers
Description

Unit tests pass.

Modified message to group errors with the addresses: "No socket could be created -- (ip1: err1) -- (ip2: err2)"

Comments (2)

  1. Jason R. Coombs

    That code seems fine if there's exactly one element in info. What if there are multiple elements in info? In that case, the various exception messages would all be included, perhaps in a strange arrangement. It might yield something like this:

    No socket could be created on 10.0.0.1 -- invalid address on 10.0.0.2 -- invalid address
    

    Perhaps there's a better way to represent the error for multiple info items?