Issue #1443 new

Trial prices not working for subscription products

Tomas Neme
created an issue

When OrderItems are created at the checkout process, they are created with the right price by {{{payment.utils.update_orderitem}}} and {{{payment.utils.update_orderitem_for_subscription}}} but later on, at {{{Order.force_recalculate_total}}}, 'adjustments' are created for them, specifically at line 948 on the current codebase: https://bitbucket.org/chris1610/satchmo/src/43adabb8ff1d/satchmo/apps/satchmo_store/shop/models.py#cl-948 and this process ignores the trial prices.

This renders the Trial price thing effectively useless

Comments (1)

  1. Tomas Neme reporter

    This was introduced in bcb26b853dfd, specifically, I don't understand this line: https://bitbucket.org/chris1610/satchmo/changeset/bcb26b853dfd9ee14a3ba33d9ff247cd77fc1d15#chg_satchmo/apps/satchmo_store/shop/models.py_newline834

    why is it if baseprice > finalprice or baseprice != lineitem.unit_price and not if baseprice > finalprice or finalprice < lineitem.unit_price or in general, why isn't lineitem.unit_price taken into account in that calculation? Shouldn't just the minimum of them all be used?

  2. Log in to comment