moneyfmt doesn't accept blank strings

Create issue
Issue #88 resolved
Former user created an issue

file: shop/templatetags/currency_filter.py line: 38

... value = Decimal(str(value)) ...

Will throw a ConversionSyntax exception if "value" is equal to u''.

Not sure if this should be made more robust, by checking for the empty string? Is the intended result of such a value, zero by default?

This will result in 'currency' template tag failing, and not properly displaying the correct total amount in your cart.

Reported by markph

Comments (2)

  1. Former user Account Deleted

    Most likely it was a result of having an item in the cart, but then removing that product. How real is this scenario? Probably very little. Found it during testing and playing around with adding removing products/variations in new product model branch.

  2. Log in to comment