Chris Doble avatar Chris Doble committed 91a1ec3

Fix pagination bug, improve no results message.

Comments (0)

Files changed (2)

src/main/java/com/atlassian/bamboo/plugins/failureleaderboard/ViewFailureLeaderboard.java

 
     @Override
     public List<TestCaseFailures> getFilteredResultsList(int firstResult, int maxResults) {
-        int toIndex = Math.min(getLeadingTestCaseFailures().size(), firstResult + maxResults);
-        return getLeadingTestCaseFailures().subList(firstResult, toIndex);
+        List<TestCaseFailures> leadingTestCaseFailures = getLeadingTestCaseFailures();
+        int from = Math.min(leadingTestCaseFailures.size(), firstResult);
+        int to = Math.min(leadingTestCaseFailures.size(), firstResult + maxResults);
+        return leadingTestCaseFailures.subList(from, to);
     }
 
     @Override

src/main/resources/templates/viewFailureLeaderboard.ftl

                 [/#if]
             </table>
         [#else]
-            <p>No builds have been run.</p>
+            <p>There are no builds, no tests, or no failures!</p>
         [/#if]
     </div>
 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.