Fix documentation error: no disable-javascript command-line flag

[swagata-daffodil]

I have tried to disable javascript via command line switch disable-javascript. But it isnt working. I am using cefsharp wpf which is using cef3.

[Marshall Greenblatt]

There is no such command-line flag.

[amaitland]

To be fair, the documentation says there is such a flag.

http://magpcss.org/ceforum/apidocs3/projects/%28default%29/_cef_browser_settings_t.html#javascript

[Marshall Greenblatt]

@amaitland: Thanks for pointing that out, we should fix the documentation.

[amaitland]

Out of curiosity are the other javascript related command line options referenced in the doc valid? e.g. disable-javascript-close-windows?

[Marshall Greenblatt]

Yes, the other flags are implemented in CEF (libcef/common/cef_switches.cc). The "disable-javascript" flag was likely implemented in Chromium at one time. We could implement support for it in CEF (so that it works again), but it's probably better to retire flags that Chromium no longer supports.

[amaitland]

Sounds reasonable. Thanks for clarifying (One day bitbucket will implement a web based code search feature).

Just looking at the switches file now, is enable-npapi still relevant in master? (off topic, happy to discuss on ceforum).

https://bitbucket.org/chromiumembedded/cef/src/77746cfd1b863753ba05811cae89d2e79204cdb6/libcef/common/cef_switches.cc?at=master&fileviewer=file-view-default#cef_switches.cc-111

[Marshall Greenblatt]

is enable-npapi still relevant in master?

Well, Chromium hasn't deleted the ContentBrowserClient::IsNPAPIEnabled() method yet, so it might still do something :)

[Marshall Greenblatt]

--disable-javascript flag restored in master revision 64cd460.