OSR: Generated characters from keyboard events are wrong

Issue #2892 resolved
Mike Wiedenbauer created an issue
  1. ./cefclient --off-screen-rendering-enabled
  2. in the google search bar type: AltGr + 2 expected ‘@' acutal ‘2’ or Shift + 2 expected ‘“’ actual '@'
  3. cef 80.3987, ubuntu 18.04LTS
  4. Yes, reproduced with cefclient. Older, 79.3945, works as expected
  5. No

It seems CefBrowserPlatformDelegateNativeAura::TranslateWebKeyEvent() does not handle the character and unmodified_character fields of CefKeyEvent.

To me it also seems CefBrowserPlatformDelegateNativeLinux::TranslateUiKeyEvent() is not properly translating at all.

Comments (17)

  1. Marshall Greenblatt

    Looks like ViewsTextfieldTest.TextfieldKeyEvent is also failing on Linux at M81. Not sure if it’s related.

  2. Mike Wiedenbauer reporter

    on Linux M80, ViewsTextfieldTest.TextfieldKeyEvent, fails too. But here with a test timeout. What’s the result on M81?

  3. Mike Wiedenbauer reporter

    Update:

    I’ve analysed it a bit more and thus far UIControlsDesktopX11::SendKeyPressNotifyWhenDone and aura::test::PostEventToWindowTreeHost() respectively do not trigger an actual keypress on the textfield widget. And hence the textfield delegate handler(s) of the unittest are not executed. A real user action on the focused textfield will trigger them, tho.

  4. Mike Wiedenbauer reporter

    @Daniel Raban It’s likely that this is related. Have you tried with the PR? Does this solve?

    Just tested myself, but couldn’t even get it to work without OSR mode.

  5. Marcel S

    I think this deserves more attention that it’s getting.. quite impactful bug. Imagine not being able to enter your e-mail on a webpage..

  6. Mike Wiedenbauer reporter

    Not sure how much the other platforms are affected (Win, MacOSX) but i got that issue under Linux especially. For that reason i already created a PR.

    Unfortunately the PR is pending due to unit test failures under Win10 (although the PR applies only to Linux)

  7. Marcel S

    @Mike Wiedenbauer the link Pedro provided (that project is based on Windows) demonstrates that it impacts Windows as well.

    Therefore, i think a PR that fixes it for all platforms (not just Linux) would be the only appropiate solution to close this issue.

  8. Daniel Raban

    @Mike Wiedenbauer

    It’s likely that this is related. Have you tried with the PR? Does this solve?

    Just tested myself, but couldn’t even get it to work without OSR mode.

    My issue seems to persist even with mentioned PR

  9. Mike Wiedenbauer reporter

    Well, initially i thought it might relate to this issue. But thoroughly reading your open issue it looks more like an issue with some kind of shortcut key handling or the like.
    Anyways. As soon as i get too i‘ll take a look at it again.

  10. Log in to comment