Add API for SSL status (including server certificate) retrieval (issue #1924)

#67 Declined
Repository
mlafon
Branch
SSLSTATUS-API
Repository
chromiumembedded
Branch
master
Author
  1. Mathieu Lafon
Reviewers
Description
  • Add CefSSLStatus matching chrome content::SSLStatus
  • Move most certificate-related API from CefSslInfo to new CefX509Certificate
  • Add GetX509Certificate() to retrieve certificate from CefSslInfo object
  • Rename CefSSLCertPrincipal into CefX509CertPrincipal
  • Add GetSSLStatus() to retrieve CefSSLStatus from CefNavigationEntry object
  • Add GetVisibleNavigationEntry() to retrieve current visible navigation entry from CefBrowserHost object
  • Add 'Show SSL information' contextual menu in cefclient

Comments (6)

  1. Mathieu Lafon author

    PR has been updated regarding comments.

    The only remaining point is the GetSSL/GetSSLStatus method name. GetSSL has been chosen to match Chrome method name in content::NavigationEntry. Is it preferred in CEF to match Chrome methods or to match returned objet name?

  2. Marshall Greenblatt

    Thanks, manually merged to master in revision 10c1fd6 and 2840 branch in revision c83b6a1 with minor changes. Marking this PR as "Declined" due to the manual merge.