Remove curse doesn't work on objects in inventory
Issue #20
closed
If a character is holding a cursed item in their inventory, but can't wear or hold the item themselves, the cleric remove curse prayer doesn't see the cursed item.
In disc_aegis.cc, removeCurseBeing function it looks like it only checks the target's worn equipment which would explain why this cursed bracer in my inventory can't be uncursed...
Comments (6)
-
-
This was me, not sure why I wasn't logged in. I haven't played in awhile but if I remember right the char who had the bracer in his inv couldn't hold it due to eq restrictions. It was a simple metal bracer but was anti-thief or whatever class he was, which stopped him from being able to hold it to allow the curse to be removed. Probably should've mentioned that in my initial report.
-
I looked again and did find where that is happening in
TBeing::canUseEquipment. I suppose that in the olden days this'd be fixed by petitioning an immortal to remove the item, but a better solution is required. I can't just let people hold wrong-class weapons, but I could let everyone hold any cursed item. Of course, then it would be stuck in your hand...I did have fun looking up the 35 cursed items in the db though. Also it seems that de-cursing doesn't persist across renting.
-
Also, drew, since there's no way to contact people directly on bitbucket, I invite you to come with us to github:
https://github.com/sneezymud/sneezymud
Also we are on irc.freenode.net in the #sneezydev channel, you can webchat via https://webchat.freenode.net/
-
Ported this bug to github with a PR, it can be closed here.
-
repo owner
- changed status to closed
Migrated to GitHub, closing
- Log in to comment
I can only imagine that the reporter was using 'wield' instead of 'hold' when they wanted to brandish their bracer. I don't see any code that checks if an item wants to be held or not. The developers have always required the target to hold the item before removing the curse, probably in pursuit of versimilitude.