Doug Hellmann avatar Doug Hellmann committed 769e9d3

use tempfile to create temporary files instead of the process id so the filenames are less predictable

Comments (0)

Files changed (2)

docs/source/history.rst

 
   - Add support for ksh.  Thanks to Doug Latornell for doing the
     research on what needed to be changed.
+  - Switch to ``tempfile`` command for creating temporary hook files.
 
 2.0.2
 

virtualenvwrapper.sh

     # First anything that runs directly from the plugin
     "$VIRTUALENVWRAPPER_PYTHON" -m virtualenvwrapper.hook_loader $HOOK_VERBOSE_OPTION "$@"
     # Now anything that wants to run inside this shell
+    hook_script=$(tempfile --directory "$VIRTUALENVWRAPPER_TMPDIR")
     "$VIRTUALENVWRAPPER_PYTHON" -m virtualenvwrapper.hook_loader $HOOK_VERBOSE_OPTION \
-        --source "$@" >>$VIRTUALENVWRAPPER_TMPDIR/$$.hook
-    source $VIRTUALENVWRAPPER_TMPDIR/$$.hook
-    rm -f $VIRTUALENVWRAPPER_TMPDIR/$$.hook
+        --source "$@" >>"$hook_script"
+    source "$hook_script"
+    rm -f "$hook_script"
 }
 
 # Set up virtualenvwrapper properly
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.