charettes avatar charettes committed a618c9c

Avoid has_ddl_transactions feature detection if the backend doesn't support transactions in the first place

Comments (0)

Files changed (1)

south/db/generic.py

     @cached_property
     def has_ddl_transactions(self):
         self._possibly_initialise()
-        cursor = self._get_connection().cursor()
-        self.start_transaction()
-        cursor.execute('CREATE TABLE DDL_TRANSACTION_TEST (X INT)')
-        self.rollback_transaction()
-        try:
+        connection = self._get_connection()
+        if connection.features.supports_transactions:
+            cursor = connection.cursor()
+            self.start_transaction()
             cursor.execute('CREATE TABLE DDL_TRANSACTION_TEST (X INT)')
-        except DatabaseError:
+            self.rollback_transaction()
+            try:
+                cursor.execute('CREATE TABLE DDL_TRANSACTION_TEST (X INT)')
+            except DatabaseError:
+                return False
+            else:
+                return True
+            finally:
+                cursor.execute('DROP TABLE DDL_TRANSACTION_TEST')
+        else:
             return False
-        else:
-            return True
-        finally:
-            cursor.execute('DROP TABLE DDL_TRANSACTION_TEST')
 
     def __init__(self, db_alias):
         self.debug = False
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.