Code Formatting
Issue #19
resolved
Several classes do not use Java best practices for code formatting. For instance, there are missing brackets on single-line if statements. These should be updated and fixed for maintainability and readability of the codebase.
Comments (7)
-
-
reporter I've never incorporated something like that into the build process, could be good here (and I'd probably do it on other projects, too). I was more thinking of just doing a one-time pass with a code formatter. I can run that if you're OK with it.
-
Could you run your code formatter on a new branch? I'm a bit anxious what would come out of it :) Cheers!
-
reporter Pushed as
code-format-cleanup
. The cleanup function did several things:- Fix indentation (hard tabs everywhere, which seemed to be the standard before anyway)
- Organized imports (expanded wildcards, alphabetized entries, removed unused imports)
- Wrapped all single-line conditional and loops with explicit brackets
- Added missing @Overrides and other annotations.
-
reporter - changed status to open
-
reporter -
assigned issue to
-
assigned issue to
-
- changed status to resolved
Fixed in commit 35b824d
- Log in to comment
Oh, I do that a lot :) And don't mind at all ;)
What do you think about incorporating checkstyle into the build process?