Some tests do not fail for missing exceptions

[Former user]

Some tests check for expected exceptions by using try-catch. However, not in all cases a missing exception is detected properly, so the test passes even if the expected exception is not thrown.

Examples:

• https://bitbucket.org/connect2id/nimbus-jose-jwt/src/651580526d8e815420e06abe31c0b4976c4afec9/src/test/java/com/nimbusds/jose/crypto/ECDSATranscodingTest.java#lines-179

• https://bitbucket.org/connect2id/nimbus-jose-jwt/src/651580526d8e815420e06abe31c0b4976c4afec9/src/test/java/com/nimbusds/jose/crypto/ECDSATranscodingTest.java#lines-205

A fail() call (or similar) is missing at the end of the try block. There might be more affected test classes.

Maybe it would also be an option to use JUnit's assertThrows (which has also been added to JUnit 4), but since this project still seems to use Java 7, using assertThrows without lambdas is probably rather cumbersome.

[Vladimir Dzhuvinov]

Thanks for pointing those lapses :)

[Vladimir Dzhuvinov]

Did a scan for missing fails - all should be fixed now: 945d35b8