com.nimbusds.srp6.cli.SRP6Tool bug
protected void println(String msg){ println(msg); } is recursive call. So SRP6Client and SRP6Server run with StackOverflowError. Must be protected void println(String msg){ System.out.println(msg); } Sorry for my bad english... Vladimir Gamaley mailto:gamaleyvv@gmail.com
Comments (5)
-
-
Hi,
I’m not allowed to create PR (God knows why) but here’s a fixing commit: https://bitbucket.org/Warkdev/nimbus-srp/commits/cca9aa73d71ec2c79692e1e0e5702339328d02c8
-
FYI, it has been added in this commit: https://bitbucket.org/connect2id/nimbus-srp/commits/a7c9c02b2f4297dfef77a606744542792a900f92
-
FYI: Both 2.0.1 and 2.0.2 contains this bug.
-
Thanks Cedric I have put this onto master.
@Vladimir Dzhuvinov The build pipeline got an error connecting to sonarcube.com I don’t have the login to token to try to see what is going wrong https://bitbucket.org/connect2id/nimbus-srp/addon/pipelines/home#!/results/branch/master/page/1
I have disabled sonar:sonar in the bitbucket-pipelines.yml and move the previous command to be a comment https://bitbucket.org/connect2id/nimbus-srp/commits/5817bb478c0dd288206dc4ec48b8885322c6e06b perhaps you could take a look and release this minor bug fix as 2.0.3?
- Log in to comment
Apologies that this has gone unnoticed for a while. Do you want to send use a pull request of the fix for us to merge?