Upgrade nimbus-jose-jwt to v9
Issue #313
resolved
The current nimbus-jose-jwt dependency is at 8.18
<dependency>
<groupId>com.nimbusds</groupId>
<artifactId>nimbus-jose-jwt</artifactId>
<version>8.18</version>
</dependency>
Version 9 is released and it would be good to upgrade this dependency. Breaking changes are to be expected as the upgrade has changed a method name for toJSONString().
I can definitely submit a pull request for this issue, if that is agreeable.
Comments (9)
-
-
Your thoughts on shading JSON Smart in the OAuth SDK also?
-
reporter Thank you @Vladimir Dzhuvinov . I have a functioning build with v9. Things to note:
- json-smart is removed since it’s shaded in.
- I am building with JDK 11 and see a lot of javadoc errors. For the time being, I have disabled the linter.
- Removed a lot of unused imports.
- The resulting changeset contains about 270 modified files. Should I submit this as a pull request?
-
Yes please, looking forward to it!
-
SUperb!
-
@Yavor Vasilev
Hi, Yavor. When is the nimbus-jose-jwt v9 supported? BR Ugi
-
Well, if a PR doesn’t appear we might have to do it ourselves :)
-
Thank you
-
- changed status to resolved
Merged 9.x support now: 0c52dd9f
- Log in to comment
Wow, this will be very much appreciated
If you encounter any issues with the upgrade drop us a note here.
It’s going to be a breaking change, but no worries, we’ll make it a new major release so that everyone is in the clear about that.