Allow certain classes to be extended, remove final

[Vladimir Dzhuvinov]

Reported by Kanishk Panwar Date: Mon, 13 Jan 2014 09:13:36 -0800 (01/13/2014 07:13:36 PM)

---

Hey Vladimir,

I really like your work on the OAuth/OpenId/JWT sdk and have decided to use it for our need. I was wondering if you could make the classes more open (remove final) to allow extensibility. For example, 1) I would like to pass a custom parameter in the header to the server (request id) and receive custom parameter back as a response for OAuth Token requests. 2) Also, I am considering using Apache HTTP Client for my http request and response handling.

Is there anyway you would consider loosening the final keyword from the implementation classes and allow for different http request response frameworks to work with the sdk cleanly?

Thanks, Kanishk

[Vladimir Dzhuvinov]

Removed final from HTTP request and response classes in commit 49dfe62.

[Vladimir Dzhuvinov]

Removed final from OIDC request and response classes, other selected classes as well, commit 1e982ba.

[Vladimir Dzhuvinov]

If you think there is a more efficient way than extending to allow other HTTP clients, such as the one from Apache, I'm open to suggestions :)

In December I was running a bunch of performance tests against our OpenID Connect server using the stock HttpURLConnection class and I remember it had a few problems.

[Vladimir Dzhuvinov]

Got this change out as part of today's 2.14 release, should be available on Maven Central later today.