Identifier should implement Serializable
Can com.nimbusds.oauth2.sdk.id.Identifer implement java.io.Serializable?
This would allow these types to be used in contexts that require serializable values, for example EJB parameters or replicated caches.
Comments (8)
-
-
- changed status to resolved
Done in commit faf5399.
If you think other classes have need for that let us know. We use external serialisers in our Connect2id server code, so never had this need.
-
reporter Thanks for the quick response! Most of the types that need to be stored between requests (State, Nonce, ClientID, AccessToken etc.) seem to extend Identifier, so they should be covered by this change.
-
BTW, the OAuth WG has just produced a useful draft for encoding the state using JWTs:
http://tools.ietf.org/html/draft-bradley-oauth-jwt-encoded-state-01
-
reporter Any news on this? It is marked as resolved, but the change doesn't seem to be present in version 3.4.1 or the latest source from git.
-
- changed status to open
Let me check if the serialisable change was indeed merged.
-
- changed status to resolved
Serializable is now merged into master. We'll push a new fix release later today. Thank you for following up on this!
-
The fix is in the new 4.1 release, pushed to Central a minute ago.
- Log in to comment
Thanks for suggesting this. We were just preparing a new release of the SDK.