comment handling / e-mail: link to specific comments only works when page is already loaded

Issue #105 closed
Thomas De Schampheleire created an issue

Scenario: - receive a mail about a pull request comment - click on the link that points to the pullrequest#comment-xxx

The pullrequest will open, but your browser (at least Firefox) will not jump to the comment. Once the page is loaded, you can reload the URL and then you jump correctly.

I assume this is because the comments are loaded dynamically, and the anchor is not yet available when the browser wants to jump, but I'm not sure.

Comments (5)

  1. Mads Kiilerich

    9dfd9d242728 was supposed to fix that ... and it works for me.

    I have only seen it fail when I had javascript errors that prevented the browser from reaching that code?

  2. Log in to comment