Add Option for Global Pull Changes [_admin/settings/mapping]

Issue #30 new
seanmccully created an issue

The idea, hosting multiple repositories cloned/imported from various remote repositories is to allow an option to perform a Pull Change Operation across all repositories.

This appears to fit well in admin settings for 'Remap and Rescan' as an additional checkbox.

Comments (3)

  1. seanmccully reporter

    There was actually a sligh bug in that patch that wasn't committed yet.

    diff --git a/kallithea/controllers/admin/settings.py b/kallithea/controllers/admin/settings.py
    --- a/kallithea/controllers/admin/settings.py
    +++ b/kallithea/controllers/admin/settings.py
    @@ -213,8 +213,9 @@
                 if pull_changes:
                     for repo in filesystem_repos:
                         try:
    -                        ScmModel.pull_changes(repo, self.auth.username)
    -                    except Exception:
    +                        ScmModel().pull_changes(repo, self.authuser.username)
    

    !python

    
    
  2. Mads Kiilerich

    Hmm. It is already possible to pull repos one by one from repo settings.

    The remap&rescan establishes consistency after making changes outside Kallithea. Pulling for all repos would be something very different.

    I also think most installations either will be so small that it is feasible to pull for each repo separately or it doesn't "scale" (both performance wise and by repos being different) to pull for all repos globally. Most users of this will probably also want to do this regularly. A good solution to this will thus require some kind of scripting ... and it is already trivial to do it with scripting outside Kallithea.

    I think the feature as proposed here will miss the point.

  3. seanmccully reporter

    I agree that this may not fit well in remap&rescan, but I also think because it is either a) something that users will want to do regurarly and b) when there are more then one repos having an option to do all at the same time or even more then one is a big convenvience factor.

    This being a [potentially] long operation due to size of repos seems to be consitent with the way Kallithea handles other long running operations. I think this a valuable feature, and would be remiss to not see it as some option in the user interface. As such I am open to suggestions on where this may best fit.

  4. Log in to comment