Crowd authorization module doesn't allow https connections

Issue #315 resolved
Chris Rule created an issue

The current crowd authorization module only allows http connections to the crowd server for authorization. This means that crowd servers hosted behind a proxy to server https or direct using https cannot be used by the current auth_crowd.py plugin.

What I expected: To be able to connect to crowd using https. What I got: There's no way to configure the crowd authorization to use https.

It appears the back-end code is written for it. There just isn't an interface option.

Comments (6)

  1. Chris Rule reporter

    Adding a 'method' setting appears to work for me. I've added a patch to this issue detailing what I changed. I opted to use a checkbox to represent https connections (if checked, use https to connect to crowd. If not, use http). If the patch needs to be submitted a different way, please let me know.

  2. Thomas De Schampheleire

    Thanks for the patch. I modified it slightly to use a dropdown with options http/https instead of the checkbox, as this avoids a separate conversion from boolean to string. Other than that it looked fine. We'll see what the maintainer @kiilerix prefers.

    Could you let me know your email address so we can properly attribute the contribution? Currently the patch only contained 'crule'.

  3. Chris Rule reporter

    Have no problem with a drop down. I originally thought check boxes would be easier for the user.

    Sounds like a plan. Thanks for looking at it.

    My email is "crule" at "aegistg.com".

  4. Log in to comment