- changed status to resolved
Crash when mail cannot be sent
Issue #15
resolved
When, after placing a comment, the email could not be sent, the server returns a 500 error. That seems a bit harsh since the comment was successfully placed…
ERROR in app: Exception on /claims/451/comments/add [POST]
Traceback (most recent call last):
File "/Users/jelmer/Sites/cover/reclaim-venv/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/Users/jelmer/Sites/cover/reclaim-venv/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/jelmer/Sites/cover/reclaim-venv/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Users/jelmer/Sites/cover/reclaim-venv/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/jelmer/Sites/cover/reclaim-venv/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/Users/jelmer/Sites/cover/reclaim-venv/lib/python2.7/site-packages/flask_coverapi/utils.py", line 54, in decorated_view
return func(*args, **kwargs)
File "/Users/jelmer/Sites/cover/reclaim/reclaim/views.py", line 324, in comments_add
mail_for_comment(comment, claim)
File "/Users/jelmer/Sites/cover/reclaim/reclaim/utils.py", line 177, in mail_for_comment
mail.send(msg)
File "/Users/jelmer/Sites/cover/reclaim-venv/lib/python2.7/site-packages/flask_mail.py", line 491, in send
with self.connect() as connection:
File "/Users/jelmer/Sites/cover/reclaim-venv/lib/python2.7/site-packages/flask_mail.py", line 144, in __enter__
self.host = self.configure_host()
File "/Users/jelmer/Sites/cover/reclaim-venv/lib/python2.7/site-packages/flask_mail.py", line 158, in configure_host
host = smtplib.SMTP(self.mail.server, self.mail.port)
File "/Users/jelmer/.brew/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/smtplib.py", line 256, in __init__
(code, msg) = self.connect(host, port)
File "/Users/jelmer/.brew/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/smtplib.py", line 316, in connect
self.sock = self._get_socket(host, port, self.timeout)
File "/Users/jelmer/.brew/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/smtplib.py", line 291, in _get_socket
return socket.create_connection((host, port), timeout)
File "/Users/jelmer/.brew/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 575, in create_connection
raise err
error: [Errno 61] Connection refused
127.0.0.1 - - [30/Jun/2017 02:19:06] "POST /claims/451/comments/add?next=http%3A%2F%2Freclaim.svcover.dev%2Fclaims%2F451 HTTP/1.1" 500 -
Comments (1)
-
- Log in to comment
Fixed in python3 branch