Error Student Not In Any Group

[Jeremy Hopkins]

If a student tries to access peer assessment but are not a member of a group they see the following error message.

This is also the case if a student is removed from a group after the grade / feedback is given, then tries to enter the activity.

I do not think we should try to allow students to access past work if they are subsequently removed from the group as this may be a deliberate decision by the tutor.

I think the best we can do is make the message more meaningful.

“You must belong to a group to access this activity, please speak to your tutor if you think you should have access to this”

‌

[Jeremy Hopkins]

@Kevin Moore it appears this is using the core string availability_group, I am not sure if there is any value in adding a separate string for this or whether customising the core string would be better.

I am guessing this exception is thrown via core so adding another string may be more effort than it is worth.

I would be inclined to just customise the core message.

‌

[Frédéric Massart]

For the record, the plugin does not handle students being removed from their groups, or being moved to another group. Which means that this could get messy. A possible way forward is to observe changes in group membership and drop all the information known about a student when their assigned group changes. This would - at the very least - prevent orphan data to be left in the database, and prevent unexpected data when a user would appear in the database twice for the same activity.

Regarding error messages and strings, another message appears if the student belongs to multiple groups.

[Frédéric Massart]

Note that the language string is hardcoded, although it is the same as the availability plugin. I will fix this in #38 with the other missing one.

[Amanda Doughty]

We had an observer in the original plugin but it was added after Coventry started working on this one. I have added it back. Now any group changes will result in an update to local and (released) gradebook grades.

This change will be in the next release.

[Amanda Doughty]

Observer now updates activity when group membership changes.