Cannot get beyond New settings - Header on fresh install of moodle 3.1 with Adaptable in the theme directory

[Diane Soini]

I can install moodle 3.1 without adaptable in the theme directory and then just add it afterward and run the upgrade, but I cannot install moodle with adaptable in the theme directory. I get stuck at the step asking for New settings - Header with a message "The settings shown below were added during your last Moodle upgrade. Make any changes necessary to the defaults and then click the "Save changes" button at the bottom of this page.". There is no form displayed so nothing can be entered and the installation script cannot proceed.

[Diane Soini]

I think I found solutions to this. 1. array_definitions.php line 846. The variable name is incorrect. Should be "$from35to100percent". 2. header_menus.php around lines 40 and 47. Passing in $default but it was not previously set. 3. header_navbar_menu.php around line 44. Same, $default not set. 4. buttons.php line 30. Looks like the name of the new admin_setting_heading is inconsistent with the other pages, changing it provides consistency but isn't related to this problem.

When I fixed these issues, I was no longer getting stuck on the upgradesettings.php page with the message "New settings - Header".

[Info 3bits]

Fixed in 1.2.4