Help popups not working with Moodle 3.4

[Nick Phillips]

In order for help popups to work with Moodle 3.4, core/first needs to be pulled in as an AMD module, either required in similar manner to bootstrapbase/javascript/moodlebootstrap.js, or by an AMD module pulled in by js_call_amd:

define(['jquery',
        'core/first',
        'theme_adaptable/whatever',
        'theme_bootstrapbase/bootstrap'], function($) {

...

[Info 3bits]

Could you clarify what pop-ups are not working well?

New version is developed over 3.4 and we can't see any issue regarding pop-ups

[Jeremy Hopkins]

Is this referring to "User Tours"?

[Nick Phillips]

In e.g. edit topic, the help for each option, obtained by pressing the ? icon.

edit: for me, this opens in a new tab rather than a popup.

[Info 3bits]

Could you submit a PR with the changes proposed.

BCU and Adaptable always opened the help page in a new tab but open a pop-up would be good.

[fireinthehole]

By the way, I love this theme.

However, I noticed that the ticker stopped working on upgrade to latest adaptable and Moodle 3.4. Here is the html code I used in the ticker box. The ticker is stuck on the first news item. I am using php 7.1.

<p>The roots of education are bitter, but the fruit is sweet. Aristotle</p> <p>The best and most beautiful things in the world cannot be seen or even touched - they must be felt with the heart.  Helen Keller</p> <p>Develop a passion for learning. If you do, you will never cease to grow.  Anthony J. D'Angelo</p> <p>Education is what remains after one has forgotten what one has learned in school. Albert Einstein</p> <p>Education is the most powerful weapon which you can use to change the world. Nelson Mandela</p> <p>Knowledge is power. Information is liberating. Education is the premise of progress, in every society, in every family. Kofi Annan</p> <p>An investment in knowledge pays the best interest. Benjamin Franklin</p> <p>Education is not preparation for life; education is life itself. John Dewey</p> <p>The roots of education are bitter, but the fruit is sweet. Aristotle</p> <p>Education is the passport to the future, for tomorrow belongs to those who prepare for it today. Malcolm X</p> <p>It does not matter how slowly you go as long as you do not stop. Confucius</p> <p>The secret of getting ahead is getting started. Mark Twain</p> <p>It always seems impossible until it's done. Nelson Mandela</p> <p>Life is 10% what happens to you and 90% how you react to it. Charles R. Swindoll</p>

Have I missed something here or is this a bug. This code works on an older version of moodle.

Thanks for any help you can provide.

Mark

[Nick Phillips]

Also now seems to need core_renderer updated, to include standard_head_html method from bootstrapbase.

[Nick Phillips]

Our local still based on Adaptable 1.5.1 I think, so can't easily work on this until we're more up-to-date.

[Manoj Solanki]

It would be useful if you can upgrade to the latest version. From1.6, there were some structural changes to the code. This includes new classes and files.

[Info 3bits]

Issue #937 was marked as a duplicate of this issue.

[Ricky Rellum]

Only thing needed is a standard_head_html method in the class theme_adaptable_core_renderer

#!
public function standard_head_html() { 
$output = parent::standard_head_html(); 
// Setup help icon overlays. 
$this->page->requires->yui_module('moodle-core-popuphelp', 'M.core.init_popuphelp'); 
$this->page->requires->strings_for_js(array( 'morehelp', 'loadinghelp', ), 'moodle'); 
return $output; 
}