Pull requests

#21 Declined
Repository
intel352
Branch
default
Repository
crisu83
Branch
default

Rewrite of logic

Author
  1. Jon Langevin
Reviewers
Description

I rewrote some of the logic behind BootActiveForm, BootInput, etc. The idea is to reduce unneeded code duplication (BootInput) which should help with maintenance going forward, and also to make BootActiveForm functionality override CActiveForm's methods.

Due to the changes made, I would suggest that rather than performing a pull/merge, you may want to instead selectively pull anything that you like in the changes I made.

One intention I have with these changes, is to eventually get BootActiveForm compliant with CForm, so that I can specify BootActiveForm in a CForm configuration, and end up with forms generated in BootActiveForm style. A bit more work is required to achieve that goal, but this work hopefully gets us closer.

This may totally clash with the usability or functionality that you envision for Yii Bootstrap, in which case, I understand :-) Just submitting in case there's anything here of value to you.

Cheers

  • Learn about pull requests

Comments (0)