Colin Gordon avatar Colin Gordon committed 7b862a2 Draft

starting to revisit after some checker fixes

Comments (0)

Files changed (2)


 import org.eclipse.ui.IPageLayout;
 import org.eclipse.ui.IPerspectiveFactory;
+import guitypes.checkers.quals.*;
  * The java monitor perspective factory.
-public class JavaMonitorPerspectiveFactory implements IPerspectiveFactory {
+@UIType public class JavaMonitorPerspectiveFactory implements IPerspectiveFactory {
     /** The folder id for navigator views. */
     private static final String ID_NAVIGATOR_FOLDER = "org.jvmmonitor.internal.ui.NavigatorFolderView"; //$NON-NLS-1$
 +30 (5:50), 19.  mostly backtracking to mark a bunch of obviously safe methods of UITypes (e.g. containing asyncExec) as SafeEffect.
 +15 (6:05), 16.  A couple safe stubs (IStructuredSelection).  Also pretty sure I've found buggy implementations of IPropertyChangeListener.
 +15 (6:20), 13.  Found a safe type (PropertySheet) and identified a few nearly-certain bugs.
++5 (6:25), 24.  Upped from some stub file & checker fixes, then marked a @UIType
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.