1. Colin Gordon
  2. jvmmonitor

Commits

Colin Gordon  committed 882e65a

Fixed the incorrect assumption that Action was polymorphic, and fixed annotation of RefreshJob, as well as many smaller fixes

  • Participants
  • Parent commits 03d4ad7
  • Branches default

Comments (0)

Files changed (47)

File jvmmonitor-read-only/.log.txt.swp

  • Ignore whitespace
Binary file modified.

File jvmmonitor-read-only/log.txt

View file
  • Ignore whitespace
 
 compile:
 [jsr308.javac] /homes/gws/csgordon/research/guitypes/checker/build.xml:40: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds
-     [copy] Copying 1 file to /homes/gws/csgordon/research/guitypes/checker/build/guitypes/checkers
 
 dist:
-      [jar] Building jar: /homes/gws/csgordon/research/guitypes/checker/dist/lib/guitypes-20120601.jar
 
 BUILD SUCCESSFUL
 Total time: 0 seconds
                                                                     ^
   found   : @AlwaysSafe Class<? extends @AlwaysSafe Object>
   required: @AlwaysSafe Class<@AlwaysSafe Object>
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/RefreshJob.java:50: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
-        refreshModel(monitor);
-                    ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/editors/AbstractDumpEditor.java:192: error: An method override may only be @UI if it overrides an @UI method (overriding @AlwaysSafe IResourceChangeListener.resourceChanged(org.eclipse.core.resources.IResourceChangeEvent)).
-        public void resourceChanged(IResourceChangeEvent event) {
-                    ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/editors/AbstractDumpEditor.java:194: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
+            if (delta != null && searchFile(delta)) {
+                                           ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/editors/AbstractDumpEditor.java:196: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
+                        .getWorkbenchWindows()) {
+                                            ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/editors/AbstractDumpEditor.java:195: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
+                for (IWorkbenchWindow window : PlatformUI.getWorkbench()
+                                                                      ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/editors/AbstractDumpEditor.java:197: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
+                    for (final IWorkbenchPage page : window.getPages()) {
+                                                                    ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/memory/HeapHistogramPage.java:170: error: An method override may only be @UI if it overrides an @UI method (overriding @AlwaysSafe IPropertyChangeListener.propertyChange(org.eclipse.jface.util.PropertyChangeEvent)).
     public void propertyChange(PropertyChangeEvent event) {
                 ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/memory/DumpHprofAction.java:151: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
-                if (isMemoryAnalyzerInstalled() && fileStore != null) {
-                                             ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/AbstractJvmPropertySection.java:209: error: An method override may only be @UI if it overrides an @UI method (overriding @AlwaysSafe IJvmModelChangeListener.jvmModelChanged(org.jvmmonitor.core.JvmModelEvent)).
-    public void jvmModelChanged(final JvmModelEvent e) {
-                ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/memory/HeapHistogramPage.java:220: error: An method override may only be @UI if it overrides an @UI method (overriding org.jvmmonitor.internal.ui.RefreshJob.refreshModel(org.eclipse.core.runtime.IProgressMonitor)).
+            protected void refreshModel(IProgressMonitor monitor) {
+                           ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/AbstractJvmPropertySection.java:216: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
+        if (!isSectionActivated && !propertySheet.isPinned()) {
+                                                          ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/memory/SWTResourcesPage.java:146: error: An method override may only be @UI if it overrides an @UI method (overriding org.jvmmonitor.internal.ui.RefreshJob.refreshModel(org.eclipse.core.runtime.IProgressMonitor)).
+            protected void refreshModel(IProgressMonitor monitor) {
+                           ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/AbstractSashForm.java:79: error: An method override may only be @UI if it overrides an @UI method (overriding @AlwaysSafe ISashForm.setOrientation(org.jvmmonitor.internal.ui.actions.ToggleOrientationAction.Orientation)).
     public void setOrientation(Orientation orientation) {
                 ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/AbstractFilteredTree.java:128: error: An method override may only be @UI if it overrides an @UI method (overriding @AlwaysSafe IPropertyChangeListener.propertyChange(org.eclipse.jface.util.PropertyChangeEvent)).
-    @SafeEffect public void propertyChange(PropertyChangeEvent event) {
-                            ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/AbstractFilteredTree.java:130: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
-                || getViewer().getTree().isDisposed()) {
-                                                   ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/AbstractFilteredTree.java:130: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
                 || getViewer().getTree().isDisposed()) {
                                       ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/editors/CpuDumpEditor.java:139: error: An method override may only be @UI if it overrides an @UI method (overriding @AlwaysSafe ICpuModelChangeListener.modelChanged(org.jvmmonitor.core.cpu.CpuModelEvent)).
             @UIEffect public void modelChanged(CpuModelEvent event) {
                                   ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/overview/OverviewSection.java:287: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
-            super(section);
-                 ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/overview/OverviewLabelProvider.java:16: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
-public class OverviewLabelProvider extends LabelProvider implements
-       ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/overview/OverviewSection.java:140: error: An method override may only be @UI if it overrides an @UI method (overriding org.jvmmonitor.internal.ui.RefreshJob.refreshModel(org.eclipse.core.runtime.IProgressMonitor)).
+            protected void refreshModel(IProgressMonitor monitor) {
+                           ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/thread/ThreadsSection.java:72: error: An method override may only be @UI if it overrides an @UI method (overriding org.jvmmonitor.internal.ui.RefreshJob.refreshModel(org.eclipse.core.runtime.IProgressMonitor)).
+            protected void refreshModel(IProgressMonitor monitor) {
+                           ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/thread/ThreadFilteredTree.java:117: error: An method override may only be @UI if it overrides an @UI method (overriding @AlwaysSafe IPropertyChangeListener.propertyChange(org.eclipse.jface.util.PropertyChangeEvent)).
     public void propertyChange(PropertyChangeEvent event) {
                 ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/timeline/TimelineChart.java:100: error: An method override may only be @UI if it overrides an @UI method (overriding @AlwaysSafe IPropertyChangeListener.propertyChange(org.eclipse.jface.util.PropertyChangeEvent)).
     public void propertyChange(PropertyChangeEvent event) {
                 ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/actions/AbstractClearAction.java:42: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
-                return doRun(monitor);
-                            ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/timeline/NewChartAction.java:120: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
-            super(shell, "", null, new ArrayList<MBeanAttribute>(), jvm, true); //$NON-NLS-1$
-                 ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/timeline/AttributeSelectionDialog.java:202: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
                         .getSelection();
                                      ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/CallerCalleeTabPage.java:95: error: An method override may only be @UI if it overrides an @UI method (overriding @AlwaysSafe ICpuModelChangeListener.modelChanged(org.jvmmonitor.core.cpu.CpuModelEvent)).
             @UIEffect public void modelChanged(CpuModelEvent event) {
                                   ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/CallTreeFilteredTree.java:32: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
-        super(parent, actionBars);
-             ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/actions/ClearCpuProfilingDataAction.java:40: error: An method override may only be @UI if it overrides an @UI method (overriding org.jvmmonitor.internal.ui.actions.AbstractClearAction.doRun(org.eclipse.core.runtime.IProgressMonitor)).
+    protected IStatus doRun(IProgressMonitor monitor) {
+                      ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/PackageLabelProvider.java:17: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
 public class PackageLabelProvider extends LabelProvider {
        ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/actions/ConfigureCpuProfilerAction.java:118: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
                 return doConfigure(monitor, dialog);
                                   ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/AttributesTab.java:233: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
+                        && !section.isRefreshSuspended()) {
+                                                      ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/AttributesTab.java:351: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
+                                adjustedValue = getNumber(node.getValue()
+                                                         ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/NotificationFilteredTree.java:152: error: An method override may only be @UI if it overrides an @UI method (overriding @AlwaysSafe IPropertyChangeListener.propertyChange(org.eclipse.jface.util.PropertyChangeEvent)).
     public void propertyChange(PropertyChangeEvent event) {
                 ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/NotificationsTab.java:151: error: An method override may only be @UI if it overrides an @UI method (overriding org.jvmmonitor.internal.ui.RefreshJob.refreshModel(org.eclipse.core.runtime.IProgressMonitor)).
+            protected void refreshModel(IProgressMonitor monitor) {
+                           ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/SubscribeAction.java:76: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
                 setEnabled(enabled);
                           ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/SubscribeAction.java:78: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
                     setChecked(jvm.getMBeanServer().getMBeanNotification()
                               ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/MBeanSashForm.java:96: error: An method override may only be @UI if it overrides an @UI method (overriding org.jvmmonitor.internal.ui.RefreshJob.refreshModel(org.eclipse.core.runtime.IProgressMonitor)).
+            protected void refreshModel(IProgressMonitor monitor) {
+                           ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/OperationsContentProvider.java:16: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
 public class OperationsContentProvider extends ArrayContentProvider {
        ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/InvokeDialog.java:481: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
                 setMessage(NLS.bind(Messages.mBeanOperationSucceededLabel,
                           ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/views/DeleteAction.java:75: error: incompatible types.
-        actionBars.setGlobalActionHandler(ActionFactory.DELETE.getId(), this);
-                                                                        ^
-  found   : @UI DeleteAction
-  required: @AlwaysSafe IAction
-./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/views/RenameAction.java:62: error: incompatible types.
-        actionBars.setGlobalActionHandler(ActionFactory.RENAME.getId(), this);
-                                                                        ^
-  found   : @UI RenameAction
-  required: @AlwaysSafe IAction
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/views/JvmTreeViewer.java:131: error: An method override may only be @UI if it overrides an @UI method (overriding @AlwaysSafe IJvmModelChangeListener.jvmModelChanged(org.jvmmonitor.core.JvmModelEvent)).
     public void jvmModelChanged(final JvmModelEvent e) {
                 ^
+./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/views/JvmTreeViewer.java:294: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
+                element = selection.getFirstElement();
+                                                   ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/views/StartMonitoringAction.java:109: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
                     if (!jvm.isConnected() && isEnabled()) {
                                                        ^
 ./org.jvmmonitor.ui/src/org/jvmmonitor/ui/Activator.java:108: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
         IDialogSettings settings = getDialogSettings();
                                                     ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/ui/Activator.java:109: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
-        IDialogSettings section = settings.getSection(sectionName);
-                                                     ^
-./org.jvmmonitor.ui/src/org/jvmmonitor/ui/Activator.java:111: error: Calling a method with UIEffect effect from a context limited to SafeEffect effects.
-            section = settings.addNewSection(sectionName);
-                                            ^
 57 errors

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/RefreshJob.java

View file
  • Ignore whitespace
      * @param monitor
      *            The progress monitor
      */
-    @UIEffect protected void refreshModel(IProgressMonitor monitor) {
+    protected void refreshModel(IProgressMonitor monitor) {
         // do nothing
     }
 

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/actions/AbstractClearAction.java

View file
  • Ignore whitespace
  * The abstract class for clear action.
  */
 @UIType
-@UI abstract public class AbstractClearAction extends @UI Action {
+abstract public class AbstractClearAction extends Action {
 
     /**
      * The constructor.
      *            The progress monitor
      * @return The status
      */
-    abstract protected IStatus doRun(IProgressMonitor monitor);
+    @SafeEffect abstract protected IStatus doRun(IProgressMonitor monitor);
 
     /**
      * Gets the job name.

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/actions/CollapseAllAction.java

View file
  • Ignore whitespace
  * The action to collapse all tree nodes.
  */
 @UIType
-@UI public class CollapseAllAction extends @UI Action {
+public class CollapseAllAction extends Action {
 
     /** The tree viewer. */
     private TreeViewer viewer;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/actions/ConfigureColumnsAction.java

View file
  • Ignore whitespace
  * The action to configure columns.
  */
 @UIType
-@UI public class ConfigureColumnsAction extends @UI Action {
+public class ConfigureColumnsAction extends Action {
 
     /** The configurable columns. */
     private IConfigurableColumns columns;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/actions/CopyAction.java

View file
  • Ignore whitespace
  * The action to copy the selected item clipboard.
  */
 @UIType
-@UI public class CopyAction extends @UI Action implements ISelectionChangedListener {
+public class CopyAction extends Action implements ISelectionChangedListener {
 
     /** The text data to be transfered. */
     private String textData;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/actions/OpenDeclarationAction.java

View file
  • Ignore whitespace
  * The action to open method declaration with Java editor.
  */
 @UIType
-@UI public class OpenDeclarationAction extends @UI Action implements
+public class OpenDeclarationAction extends Action implements
         ISelectionChangedListener {
 
     /** The selected class name. */

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/actions/PreferencesAction.java

View file
  • Ignore whitespace
  * The action to open preference dialog.
  */
 @UIType
-@UI public class PreferencesAction extends @UI Action {
+public class PreferencesAction extends Action {
 
     /** The preference dialog (keep reference for testing). */
     private PreferenceDialog dialog;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/actions/RefreshAction.java

View file
  • Ignore whitespace
  * The action to refresh property section.
  */
 @UIType
-@UI public class RefreshAction extends @UI Action {
+public class RefreshAction extends Action {
 
     /** The property section. */
     private AbstractJvmPropertySection section;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/actions/ShowInTimelineAction.java

View file
  • Ignore whitespace
  * The action to show in timeline tab.
  */
 @UIType
-@UI abstract public class ShowInTimelineAction extends @UI Action implements
+abstract public class ShowInTimelineAction extends Action implements
         ISelectionChangedListener {
 
     /** The selected attributes. */

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/actions/ToggleOrientationAction.java

View file
  • Ignore whitespace
  * The action to toggle orientation.
  */
 @UIType
-@UI public class ToggleOrientationAction extends @UI Action {
+public class ToggleOrientationAction extends Action {
 
     /** The dialog settings section name. */
     private static final String DIALOG_SETTINGS_NAME = "ToggleOrientationAction"; //$NON-NLS-1$

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/editors/AbstractDumpEditor.java

View file
  • Ignore whitespace
          * @see IResourceChangeListener#resourceChanged(IResourceChangeEvent)
          */
         @Override
-        public void resourceChanged(IResourceChangeEvent event) {
+        @SafeEffect public void resourceChanged(IResourceChangeEvent event) {
             IResourceDelta delta = event.getDelta();
             if (delta != null && searchFile(delta)) {
                 for (IWorkbenchWindow window : PlatformUI.getWorkbench()

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/AbstractJvmPropertySection.java

View file
  • Ignore whitespace
      * @see IJvmModelChangeListener#jvmModelChanged(JvmModelEvent)
      */
     @Override
-    public void jvmModelChanged(final JvmModelEvent e) {
+    @SafeEffect public void jvmModelChanged(final JvmModelEvent e) {
         if (e.state != State.JvmModified && e.state != State.JvmConnected
                 && e.state != State.JvmDisconnected) {
             return;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/CallTreeFilteredTree.java

View file
  • Ignore whitespace
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.TreeColumn;
 import org.eclipse.ui.IActionBars;
+import guitypes.checkers.quals.*;
 
 /**
  * The call tree filtered tree.
  */
+@UIType
 public class CallTreeFilteredTree extends AbstractFilteredTree {
 
     /**

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/CpuSection.java

View file
  • Ignore whitespace
      * @param initConfig
      *            <tt>true</tt> to initialize configuration.
      */
-    private void refresh(final boolean initConfig) {
-        new @UI RefreshJob(NLS.bind(Messages.refeshCpuSectionJobLabel, getJvm()
+    @SafeEffect private void refresh(final boolean initConfig) {
+        new RefreshJob(NLS.bind(Messages.refeshCpuSectionJobLabel, getJvm()
                 .getPid()), toString()) {
 
             private boolean isCpuProfilerReady;
             }
 
             @Override
-            protected void refreshUI() {
+            @UIEffect protected void refreshUI() {
                 IActiveJvm jvm = getJvm();
                 boolean isConnected = jvm != null && jvm.isConnected();
                 updatePage(isPackageSpecified);
      * @see AbstractJvmPropertySection#jvmModelChanged(JvmModelEvent)
      */
     @Override
-    public void jvmModelChanged(JvmModelEvent event) {
+    @SafeEffect public void jvmModelChanged(JvmModelEvent event) {
         super.jvmModelChanged(event);
 
         IActiveJvm jvm = getJvm();
     /**
      * Sets the profiled packages to CPU profiler.
      */
-    void setProfiledPackages() {
+    @SafeEffect void setProfiledPackages() {
         IActiveJvm jvm = getJvm();
         if (jvm == null) {
             return;
     /**
      * Sets the profiler sampling period.
      */
-    void setProfilerSamplingPeriod() {
+    @SafeEffect void setProfilerSamplingPeriod() {
         IActiveJvm jvm = getJvm();
         if (jvm == null) {
             return;
     /**
      * Sets the profiler type.
      */
-    void setProfilerType() {
+    @SafeEffect void setProfilerType() {
         IActiveJvm jvm = getJvm();
         if (jvm == null) {
             return;
      * 
      * @return True if CPU profiler is ready
      */
-    boolean isCpuProfilerReady() {
+    @SafeEffect boolean isCpuProfilerReady() {
         IActiveJvm jvm = getJvm();
         return jvm != null
                 && jvm.isConnected()
      * 
      * @return True if CPU profiler is running
      */
-    boolean isCpuProfilerRunning() {
+    @SafeEffect boolean isCpuProfilerRunning() {
         IActiveJvm jvm = getJvm();
         return jvm != null && jvm.isConnected()
                 && jvm.getCpuProfiler().getState() == ProfilerState.RUNNING;
      * 
      * @return True if the profiled packages are specified
      */
-    boolean isPackageSpecified() {
+    @SafeEffect boolean isPackageSpecified() {
         IActiveJvm jvm = getJvm();
         if (jvm == null
                 || jvm.getCpuProfiler().getState() == ProfilerState.AGENT_NOT_LOADED) {

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/actions/ConfigureCpuProfilerAction.java

View file
  • Ignore whitespace
  * The action to configure CPU profiler.
  */
 @UIType
-@UI public class ConfigureCpuProfilerAction extends @UI Action {
+public class ConfigureCpuProfilerAction extends Action {
 
     /** The Java packages that CPU profiler profiles. */
     Set<String> packages;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/actions/DumpCpuProfilingDataAction.java

View file
  • Ignore whitespace
  * Dumps the CPU profiling data.
  */
 @UIType
-@UI public class DumpCpuProfilingDataAction extends @UI Action {
+public class DumpCpuProfilingDataAction extends Action {
 
     /** The property section. */
     AbstractJvmPropertySection section;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/actions/FindAction.java

View file
  • Ignore whitespace
  * The action to find tree item.
  */
 @UIType
-@UI public class FindAction extends @UI Action {
+public class FindAction extends Action {
 
     /** The tree viewer. */
     private TreeViewer viewer;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/actions/FocusOnAction.java

View file
  • Ignore whitespace
  * The action to focus on frame or thread.
  */
 @UIType
-@UI public class FocusOnAction extends @UI Action {
+public class FocusOnAction extends Action {
 
     /** The selected frame node. */
     private ICallTreeNode selectedNode;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/actions/ResumeCpuProfilingAction.java

View file
  • Ignore whitespace
  * The action to resume CPU profiling.
  */
 @UIType
-@UI public class ResumeCpuProfilingAction extends @UI Action {
+public class ResumeCpuProfilingAction extends Action {
 
     /** The property section. */
     AbstractJvmPropertySection section;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/actions/ShowCallersCalleesAction.java

View file
  • Ignore whitespace
  * The action to show the callers/callees of selected method.
  */
 @UIType
-@UI public class ShowCallersCalleesAction extends @UI Action implements
+public class ShowCallersCalleesAction extends Action implements
         ISelectionChangedListener {
 
     /** The tree viewer. */

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/cpu/actions/SuspendCpuProfilingAction.java

View file
  • Ignore whitespace
  * The action to suspend CPU profiling.
  */
 @UIType
-@UI public class SuspendCpuProfilingAction extends @UI Action {
+public class SuspendCpuProfilingAction extends Action {
 
     /** The property section. */
     AbstractJvmPropertySection section;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/InvokeAction.java

View file
  • Ignore whitespace
  * The action to invoke MBean method.
  */
 @UIType
-@UI public class InvokeAction extends @UI Action implements ISelectionChangedListener {
+public class InvokeAction extends Action implements ISelectionChangedListener {
 
     /** The object name. */
     private ObjectName objectName;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/NotificationDetailsDialogAction.java

View file
  • Ignore whitespace
  * The action to open notification details dialog.
  */
 @UIType
-@UI public class NotificationDetailsDialogAction extends @UI Action implements
+public class NotificationDetailsDialogAction extends Action implements
         ISelectionChangedListener, ISharedImages {
 
     /** The dialog. */

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/NotificationFilteredTree.java

View file
  • Ignore whitespace
     ConfigureColumnsAction configureColumnsAction;
 
     /** The action to clear. */
-    @UI Action clearAction;
+    Action clearAction;
 
     /** The action to open details dialog. */
     NotificationDetailsDialogAction detailsAction;
      */
     private void createContextMenu(IActionBars actionBars) {
         final CopyAction copyAction = CopyAction.createCopyAction(actionBars);
-        clearAction = new @UI Action(Messages.clearLabel) {
+        clearAction = new Action(Messages.clearLabel) {
             @Override
-            public void run() {
+            @UIEffect public void run() {
                 notificationsTab.clear();
             }
         };

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/mbean/SubscribeAction.java

View file
  • Ignore whitespace
  * The action to subscribe notification.
  */
 @UIType
-@UI public class SubscribeAction extends @UI Action {
+public class SubscribeAction extends Action {
 
     /** The object name. */
     ObjectName objectName;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/memory/ClearHeapDeltaAction.java

View file
  • Ignore whitespace
  * The action to clear heap delta.
  */
 @UIType
-@UI public class ClearHeapDeltaAction extends @UI Action {
+public class ClearHeapDeltaAction extends Action {
 
     /** The heap composite. */
     HeapHistogramPage heapComposite;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/memory/ClearSWTResourceAction.java

View file
  • Ignore whitespace
  * The action to clear SWT resources.
  */
 @UIType
-@UI public class ClearSWTResourceAction extends @UI Action {
+public class ClearSWTResourceAction extends Action {
 
     /** The SWT resource page. */
     SWTResourcesPage resourcePage;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/memory/DumpHeapAction.java

View file
  • Ignore whitespace
  * The action to dump heap.
  */
 @UIType
-@UI public class DumpHeapAction extends @UI Action {
+public class DumpHeapAction extends Action {
 
     /** The property section. */
     AbstractJvmPropertySection section;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/memory/DumpHprofAction.java

View file
  • Ignore whitespace
  * The action to dump heap as hprof file.
  */
 @UIType
-@UI public class DumpHprofAction extends @UI Action {
+public class DumpHprofAction extends Action {
 
     /** The property section. */
     AbstractJvmPropertySection section;
      * 
      * @return <tt>true</tt> if Memory Analyzer is installed
      */
-    boolean isMemoryAnalyzerInstalled() {
+    @SafeEffect boolean isMemoryAnalyzerInstalled() {
         return Platform.getBundle("org.eclipse.mat.ui") != null; //$NON-NLS-1$
     }
 

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/memory/GarbageCollectorAction.java

View file
  • Ignore whitespace
  * The action to run garbage collector.
  */
 @UIType
-@UI public class GarbageCollectorAction extends @UI Action {
+public class GarbageCollectorAction extends Action {
 
     /** The property section. */
     AbstractJvmPropertySection section;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/overview/OverviewLabelProvider.java

View file
  • Ignore whitespace
 import org.eclipse.jface.viewers.ITableLabelProvider;
 import org.eclipse.jface.viewers.LabelProvider;
 import org.eclipse.swt.graphics.Image;
+import guitypes.checkers.quals.*;
 
 /**
  * The heap label provider.
  */
+@UIType
 public class OverviewLabelProvider extends LabelProvider implements
         ITableLabelProvider {
 

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/overview/OverviewSection.java

View file
  • Ignore whitespace
     /**
      * The action to show the attribute in timeline.
      */
+    @UIType
     private static class MyShowInTimelineAction extends ShowInTimelineAction {
 
         /**

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/thread/DumpThreadsAction.java

View file
  • Ignore whitespace
  * The action to dump threads.
  */
 @UIType
-@UI public class DumpThreadsAction extends @UI Action {
+public class DumpThreadsAction extends Action {
 
     /** The property section. */
     AbstractJvmPropertySection section;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/timeline/AbstractChartSetAction.java

View file
  • Ignore whitespace
  * The abstract class for action related to chart set management.
  */
 @UIType
-@UI abstract public class AbstractChartSetAction extends @UI Action implements
+abstract public class AbstractChartSetAction extends Action implements
         IConstants {
 
     /** The predefined overview chart set. */

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/timeline/ClearTimelineDataAction.java

View file
  • Ignore whitespace
      * @see AbstractClearAction#doRun(IProgressMonitor)
      */
     @Override
-    protected IStatus doRun(IProgressMonitor monitor) {
+    @SafeEffect protected IStatus doRun(IProgressMonitor monitor) {
         timelineSection.clear();
         return Status.OK_STATUS;
     }

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/timeline/ConfigureChartAction.java

View file
  • Ignore whitespace
  * The action to configure chart.
  */
 @UIType
-@UI public class ConfigureChartAction extends @UI Action {
+public class ConfigureChartAction extends Action {
 
     /** The chart. */
     private TimelineChart chart;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/timeline/DeleteChartAction.java

View file
  • Ignore whitespace
  * The action to delete chart.
  */
 @UIType
-@UI public class DeleteChartAction extends @UI Action {
+public class DeleteChartAction extends Action {
 
     /** The timeline chart. */
     private TimelineChart chart;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/timeline/NewChartAction.java

View file
  • Ignore whitespace
  * The action to create a new chart.
  */
 @UIType
-@UI public class NewChartAction extends @UI Action {
+public class NewChartAction extends Action {
 
     /** The property section. */
     AbstractJvmPropertySection section;
     /**
      * The dialog to create a new chart.
      */
+    @UIType
     private static class NewChartDialog extends ConfigureChartDialog {
 
         /**

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/properties/timeline/TimelineSection.java

View file
  • Ignore whitespace
      * @see AbstractJvmPropertySection#jvmModelChanged(JvmModelEvent)
      */
     @Override
-    public void jvmModelChanged(JvmModelEvent event) {
+    @SafeEffect public void jvmModelChanged(JvmModelEvent event) {
         super.jvmModelChanged(event);
 
         if (event.state == State.JvmConnected && !chartsPage.isDisposed()) {
     /**
      * Clears the monitored attributes.
      */
-    protected void clear() {
+    @SafeEffect protected void clear() {
         IActiveJvm jvm = getJvm();
         if (jvm != null) {
             for (IMonitoredMXBeanGroup group : jvm.getMBeanServer()

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/views/DeleteAction.java

View file
  • Ignore whitespace
  * The action to delete items on JVM Explorer view.
  */
 @UIType
-@UI public class DeleteAction extends @UI Action implements ISelectionChangedListener {
+public class DeleteAction extends Action implements ISelectionChangedListener {
 
     /** The terminated JVMs. */
     private List<ITerminatedJvm> jvms;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/views/NewJvmConnectionAction.java

View file
  • Ignore whitespace
  * The action to create a new JVM connection.
  */
 @UIType
-@UI public class NewJvmConnectionAction extends @UI Action {
+public class NewJvmConnectionAction extends Action {
 
     /** The tree viewer. */
     private TreeViewer viewer;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/views/OpenSnapshotAction.java

View file
  • Ignore whitespace
  * The action to open snapshot.
  */
 @UIType
-@UI public class OpenSnapshotAction extends @UI Action implements
+public class OpenSnapshotAction extends Action implements
         ISelectionChangedListener {
 
     /** The snapshots. */

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/views/RenameAction.java

View file
  • Ignore whitespace
  * The action to rename snapshot on JVM Explorer view.
  */
 @UIType
-@UI public class RenameAction extends @UI Action implements ISelectionChangedListener {
+public class RenameAction extends Action implements ISelectionChangedListener {
 
     /** The snapshot. */
     private ISnapshot snapshot;

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/views/StartMonitoringAction.java

View file
  • Ignore whitespace
  * The action to start monitoring JVM.
  */
 @UIType
-@UI public class StartMonitoringAction extends @UI Action implements
+public class StartMonitoringAction extends Action implements
         ISelectionChangedListener {
 
     /** The active JVMs. */

File jvmmonitor-read-only/org.jvmmonitor.ui/src/org/jvmmonitor/internal/ui/views/StopMonitoringAction.java

View file
  • Ignore whitespace
  * The action to stop monitoring JVM.
  */
 @UIType
-@UI public class StopMonitoringAction extends @UI Action implements
+public class StopMonitoringAction extends Action implements
         ISelectionChangedListener {
 
     /** The active JVMs. */