Commits

Colin Gordon  committed 1cf3094

4

  • Participants
  • Parent commits e90f9e5

Comments (0)

Files changed (2)

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/commands/OpenWith.java

 import org.eclipse.ui.handlers.HandlerUtil;
 
 import de.anbos.eclipse.logviewer.plugin.EditorPropertyTester;
-
-public class OpenWith implements IHandler {
+import guitypes.checkers.quals.*;
+@UI public class OpenWith implements @UI IHandler { /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	
+        @SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public void addHandlerListener(IHandlerListener handlerListener) {
 		// TODO Auto-generated method stub
 	}
 
+        @SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public void dispose() {
 		// TODO Auto-generated method stub
 	}
 		return null;
 	}
 
+        @SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public boolean isEnabled() {
 		return true;
 	}
 
+        @SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public boolean isHandled() {
 		return true;
 	}
 
+        @SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public void removeHandlerListener(IHandlerListener handlerListener) {
 		// TODO Auto-generated method stub
 	}
 +60 (2:45): 20 (plus 2 warnings about redundant annotations because I haven't fixed the postDirectSupertypes() issue yet).  A few stub fixes, largely marking the AbstractViewAction heirarchy as UITypes.  Could probably replace those with a single package annotation.
 +15 (3:00): 10.  Largely marking things like JFaceResources and (shockingly) SWT Font as mostly safe
 +15 (3:15): 8.  A UI type, and marking FieldEditor.setPropertyChangeListener as taking a @UI listener
++5 (3:20): 4.  Marked OpenWith as a UI type (plus extra safeeffects to work around postDirectSupertypes()).