Commits

Colin Gordon committed 2f3d845

More UITypes mostly

  • Participants
  • Parent commits 39aa44e

Comments (0)

Files changed (10)

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/AbstractWorkbenchAction.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public abstract class AbstractWorkbenchAction implements IWorkbenchWindowActionDelegate {
 
 	// Attribute --------------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/ConsoleOpenAction.java

 import de.anbos.eclipse.logviewer.plugin.LogFile.LogFileType;
 
 
+import guitypes.checkers.quals.*;
+@UIType
 public class ConsoleOpenAction implements IObjectActionDelegate {
 
 	IConsole resource[] = null;

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/FileOpenAction.java

 import de.anbos.eclipse.logviewer.plugin.LogFile.LogFileType;
 
 
+import guitypes.checkers.quals.*;
+@UIType
 public class FileOpenAction implements IObjectActionDelegate {
 
 	private File[] resource = null;

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/FileOpenWorkbenchAction.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class FileOpenWorkbenchAction extends AbstractWorkbenchAction {
 	
 	// Constructor ------------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/delegate/ClearHistoryActionDelegate.java

 import de.anbos.eclipse.logviewer.plugin.LogViewerPlugin;
 import de.anbos.eclipse.logviewer.plugin.preferences.FileHistoryTracker;
 
+import guitypes.checkers.quals.*;
+@UIType
 public class ClearHistoryActionDelegate implements ILogViewerActionDelegate {
 
 	// Attribute ---------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/ui/EncodingDialog.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class EncodingDialog extends Dialog {
 
 	// Attribute ---------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/ui/LogFileTypeDialog.java

 import org.eclipse.ui.console.ConsolePlugin;
 import org.eclipse.ui.console.IConsole;
 
+import guitypes.checkers.quals.*;
+@UIType
 public class LogFileTypeDialog extends Dialog {
 
 	// Attribute ---------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/ui/TabRenameDialog.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class TabRenameDialog extends Dialog {
 
 	// Attribute ---------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/viewer/LogFileViewer.java

 			fontData = JFaceResources.getDefaultFont().getFontData();
 		}
 		txtViewer.getTextWidget().setFont(new Font(Display.getCurrent(),fontData));
-		store.addPropertyChangeListener(new PropertyChangeListener());
+		store.addPropertyChangeListener(new @UI PropertyChangeListener()); // Colin Gordon: BUG? This PropertyChangeListener is certainly UI since it calls SWT widget methods, but the global preference store can fire off listeners on any thread!  Also, there's a checker bug here - should issue an error without the @UI
 		createCursorLinePainter();
 		createAndInstallPresentationReconciler();
 	}
 
 	// Inner classes ----------------------------------------------------------------
 	
-	private class PropertyChangeListener implements IPropertyChangeListener {
+	@UI private class PropertyChangeListener implements @UI IPropertyChangeListener {
 		
 			/* (non-Javadoc)
 		 * @see org.eclipse.jface.util.IPropertyChangeListener#propertyChange(org.eclipse.jface.util.PropertyChangeEvent)
 
 +30 (0:30): 382.  Marked a few types safe.
 +30 (1:00): 73.  Mostly marking things @UIType, a couple @UI Runnables
++15 (1:15): 55.  Marking @UITypes