Commits

Colin Gordon committed 39aa44e

lots of progress

Comments (0)

Files changed (15)

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/ConsolePageParticipant.java

 import org.eclipse.ui.part.IPageBookViewPage;
 
 import de.anbos.eclipse.logviewer.plugin.action.ConsoleOpenAction;
-
+import guitypes.checkers.quals.*;
+@UIType
 public class ConsolePageParticipant implements IConsolePageParticipant {
 
 	private IPageBookViewPage page;

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/ResourceUtils.java

 import org.eclipse.ui.part.MessagePage;
 import org.eclipse.ui.part.PageBookView;
 
+import guitypes.checkers.quals.*;
+@UIType
 public class ResourceUtils {
 
     static public ISelection getResourceSelection(IWorkbenchPart part) {

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/delegate/FileOpenViewActionDelegate.java

 import de.anbos.eclipse.logviewer.plugin.LogFile.LogFileType;
 import de.anbos.eclipse.logviewer.plugin.preferences.FileHistoryTracker;
 import de.anbos.eclipse.logviewer.plugin.preferences.HistoryFile;
+import guitypes.checkers.quals.*;
 
+@UIType
 public class FileOpenViewActionDelegate implements ILogViewerActionDelegate {
 
 	private String parentPath = null;

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/delegate/ILogViewerActionDelegate.java

  * See the License for the specific language governing permissions
  * and limitations under the License.
  */
+import guitypes.checkers.quals.*;
 
 public interface ILogViewerActionDelegate {
 
-	public void run(LogViewer view, Shell shell);
+	@UIEffect public void run(LogViewer view, Shell shell);
 }

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/file/ConsoleTail.java

 import de.anbos.eclipse.logviewer.plugin.LogViewerPlugin;
 import de.anbos.eclipse.logviewer.plugin.Logger;
 import de.anbos.eclipse.logviewer.plugin.ResourceUtils;
+import guitypes.checkers.quals.*;
 
 public class ConsoleTail implements IDocumentListener, Runnable {
 

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/file/document/LogDocument.java

 import de.anbos.eclipse.logviewer.plugin.LogViewerPlugin;
 import de.anbos.eclipse.logviewer.plugin.file.BackgroundReader;
 import de.anbos.eclipse.logviewer.plugin.file.IFileChangedListener;
-
+import guitypes.checkers.quals.*;
+@UIType
 public class LogDocument extends AbstractDocument implements IFileChangedListener {
 
 	// Attribute ---------------------------------------------------------------
 	/* (non-Javadoc)
 	 * @see de.anbos.eclipse.logviewer.plugin.file.IFileChangedListener#contentAboutToBeChanged()
 	 */
-	public void contentAboutToBeChanged() {
-        Runnable runnable = new Runnable() {
+	@SafeEffect public void contentAboutToBeChanged() {
+        @UI Runnable runnable = new @UI Runnable() {
             public void run() {
         		DocumentEvent event = new DocumentEvent(LogDocument.this, getStore().getLength(),0,""); //$NON-NLS-1$
         		fireDocumentAboutToBeChanged(event);
 	/* (non-Javadoc)
 	 * @see de.anbos.eclipse.logviewer.plugin.file.IFileChangedListener#fileChanged(char[])
 	 */
-	public void fileChanged(final char[] content, final boolean isFirstTimeRead) {
-        Runnable runnable = new Runnable() {
+	@SafeEffect public void fileChanged(final char[] content, final boolean isFirstTimeRead) {
+        @UI Runnable runnable = new @UI Runnable() {
             public void run() {
         		String text = new String(content);
         		int offset = calculateBacklogOffset();

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/preferences/LogViewerPreferences.java

  * See the License for the specific language governing permissions
  * and limitations under the License.
  */
-
+import guitypes.checkers.quals.*;
+@UIType
 public class LogViewerPreferences extends PreferencePage implements IWorkbenchPreferencePage {
 
 	// Attribute ---------------------------------------------------------------
 		return pageComponent;
 	}
 	
-	protected IPreferenceStore doGetPreferenceStore() {
+	@SafeEffect protected IPreferenceStore doGetPreferenceStore() {
 		return LogViewerPlugin.getDefault().getPreferenceStore();
 	}
 	

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/preferences/RuleItemReadWriter.java

  * See the License for the specific language governing permissions
  * and limitations under the License.
  */
-
+import guitypes.checkers.quals.*;
+@UIType
 public class RuleItemReadWriter {
 
 	// Constant ----------------------------------------------------------------

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/preferences/rule/RuleDialog.java

  * See the License for the specific language governing permissions
  * and limitations under the License.
  */
-
+import guitypes.checkers.quals.*;
+@UIType
 public class RuleDialog extends StatusDialog {
 
     // Attribute --------------------------------------------------------------------

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/preferences/rule/RulePreferencePage.java

  * See the License for the specific language governing permissions
  * and limitations under the License.
  */
-
+import guitypes.checkers.quals.*;
+@UIType
 public class RulePreferencePage extends PreferencePage implements IWorkbenchPreferencePage {
 
 	// Constant ---------------------------------------------------------------------
     			LogViewerPlugin.getResourceString("preferences.ruleseditor.export.dialog.selectall.text"));
     }
 
-}
+}

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/preferences/rule/TableItemColorController.java

  * See the License for the specific language governing permissions
  * and limitations under the License.
  */
-
+import guitypes.checkers.quals.*;
+@UIType
 public class TableItemColorController implements PaintListener {
 
 	// Attribute ---------------------------------------------------------------

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/ui/EncodingComboEditor.java

  * See the License for the specific language governing permissions
  * and limitations under the License.
  */
-
+import guitypes.checkers.quals.*;
+@UIType
 public class EncodingComboEditor extends FieldEditor {
 
 	// Constant ----------------------------------------------------------------

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/viewer/DamageRepairer.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class DamageRepairer implements IPresentationDamager, IPresentationRepairer {
 
     // Attribute --------------------------------------------------------------------

logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/viewer/LogFileViewer.java

  * See the License for the specific language governing permissions
  * and limitations under the License.
  */
-
+import guitypes.checkers.quals.*;
+@UIType
 public class LogFileViewer {
 
 	// Attribute ---------------------------------------------------------------
 Initial error count: 458 errors
 
 +30 (0:30): 382.  Marked a few types safe.
-
++30 (1:00): 73.  Mostly marking things @UIType, a couple @UI Runnables