Commits

Colin Gordon  committed 7db2b5c

down to 20

  • Participants
  • Parent commits a8c5cd9

Comments (0)

Files changed (18)

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/EditorPropertyTester.java

 
 import de.anbos.eclipse.logviewer.plugin.action.ConsoleOpenAction;
 import de.anbos.eclipse.logviewer.plugin.action.FileOpenAction;
+import guitypes.checkers.quals.*;
 
+@UIType
 public class EditorPropertyTester extends PropertyTester {
 
 	public EditorPropertyTester() {

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/UIImages.java

  * See the License for the specific language governing permissions
  * and limitations under the License.
  */
-
+import guitypes.checkers.quals.*;
+@UIType
 public class UIImages {
 
     // Attribute ---------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/AbstractViewAction.java

  * See the License for the specific language governing permissions
  * and limitations under the License.
  */
-
+import guitypes.checkers.quals.*;
+@UIType
 public abstract class AbstractViewAction extends Action {
 
 	// Attribute --------------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/ClearHistoryAction.java

 import de.anbos.eclipse.logviewer.plugin.UIImages;
 import de.anbos.eclipse.logviewer.plugin.action.delegate.ClearHistoryActionDelegate;
 
+import guitypes.checkers.quals.*;
+@UIType
 public class ClearHistoryAction extends AbstractViewAction {
 	
 	// Constructor -------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/CloseAllFilesViewAction.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class CloseAllFilesViewAction extends AbstractViewAction {
 
     // Constructor ------------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/FileCloseViewAction.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class FileCloseViewAction extends AbstractViewAction {
 
 	// Constructor ------------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/FileEncondingViewAction.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class FileEncondingViewAction extends AbstractViewAction {
 
     // Constructor ------------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/FileOpenViewAction.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class FileOpenViewAction extends AbstractViewAction {
 	
 	// Constructor ------------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/HistoryFileOpenViewAction.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class HistoryFileOpenViewAction extends AbstractViewAction {
 	
 	// Constructor -------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/RefreshCurrentFileViewAction.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class RefreshCurrentFileViewAction extends AbstractViewAction {
 
     // Constructor ------------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/StartTailOnAllFileViewAction.java

 import de.anbos.eclipse.logviewer.plugin.UIImages;
 import de.anbos.eclipse.logviewer.plugin.action.delegate.StartTailOnAllFileActionDelegate;
 
+import guitypes.checkers.quals.*;
+@UIType
 public class StartTailOnAllFileViewAction extends AbstractViewAction {
 
     // Constructor -------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/StartTailOnCurrentFileViewAction.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class StartTailOnCurrentFileViewAction extends AbstractViewAction {
 
     // Constructor ------------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/StopTailOnAllFileViewAction.java

 import de.anbos.eclipse.logviewer.plugin.UIImages;
 import de.anbos.eclipse.logviewer.plugin.action.delegate.StopTailOnAllFileActionDelegate;
 
+import guitypes.checkers.quals.*;
+@UIType
 public class StopTailOnAllFileViewAction extends AbstractViewAction {
 
     // Constructor -------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/StopTailOnCurrentFileViewAction.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class StopTailOnCurrentFileViewAction extends AbstractViewAction {
 
     // Constructor ------------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/action/TabRenameAction.java

  * and limitations under the License.
  */
 
+import guitypes.checkers.quals.*;
+@UIType
 public class TabRenameAction extends AbstractViewAction {
 
 	// Constructor -------------------------------------------------------------

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/commands/CopyToClipboardHandler.java

 
 import de.anbos.eclipse.logviewer.plugin.LogViewer;
 import de.anbos.eclipse.logviewer.plugin.viewer.LogFileViewer;
+import guitypes.checkers.quals.*;
 
-public class CopyToClipboardHandler implements IHandler {
+@UI public class CopyToClipboardHandler implements @UI IHandler { /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 
-	public void addHandlerListener(IHandlerListener handlerListener) {
+	@SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
+        public void addHandlerListener(IHandlerListener handlerListener) {
 		// TODO Auto-generated method stub
 
 	}
 
+	@SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public void dispose() {
 		// TODO Auto-generated method stub
 
 	}
 
-	public Object execute(ExecutionEvent event) throws ExecutionException {
+	@UIEffect public Object execute(ExecutionEvent event) throws ExecutionException {
 		LogFileViewer viewer = ((LogViewer)HandlerUtil.getActivePart(event)).getViewer();
 		StyledText text = viewer.getActualViewer().getTextWidget();
 		text.copy();
 		return null;
 	}
 
+	@SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public boolean isEnabled() {
 		return true;
 	}
 
+	@SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public boolean isHandled() {
 		return true;
 	}
 
+	@SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public void removeHandlerListener(IHandlerListener handlerListener) {
 		// TODO Auto-generated method stub
 

File logviewer/de.anbos.eclipse.logviewer.plugin/src/de/anbos/eclipse/logviewer/plugin/commands/FindReplaceHandler.java

 
 import de.anbos.eclipse.logviewer.plugin.LogViewer;
 import de.anbos.eclipse.logviewer.plugin.LogViewerPlugin;
+import guitypes.checkers.quals.*;
 
-public class FindReplaceHandler implements IHandler {
+@UI public class FindReplaceHandler implements @UI IHandler { /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 
+	@SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public void addHandlerListener(IHandlerListener handlerListener) {
 		// TODO Auto-generated method stub
 
 
 	FindReplaceAction action = null;
 	
+	@SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public void dispose() {
 		// TODO Auto-generated method stub
 
 	}
 
-	public Object execute(ExecutionEvent event) throws ExecutionException {
+	@UIEffect public Object execute(ExecutionEvent event) throws ExecutionException {
 		ResourceBundle bundle = LogViewerPlugin.getDefault().getResourceBundle();
 		if (action == null)
 			action = new FindReplaceAction(bundle,"dialog.findreplace.",(LogViewer)HandlerUtil.getActivePart(event));
 		return null;
 	}
 
+	@SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public boolean isEnabled() {
 		return true;
 	}
 
+	@SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public boolean isHandled() {
 		return true;
 	}
 
+	@SafeEffect /* Colin Gordon: anno only b/c of the postDirectSupertypes() behavior. */
 	public void removeHandlerListener(IHandlerListener handlerListener) {
 		// TODO Auto-generated method stub
 
 +15 (1:15): 55.  Marking @UITypes
 +15 (1:30): 48.  Marked a couple JFace utility classes @SafeType, plus a new UIType
 +15 (1:45): 35.  Mostly marked a couple safe types and packages.
++60 (2:45): 20 (plus 2 warnings about redundant annotations because I haven't fixed the postDirectSupertypes() issue yet).  A few stub fixes, largely marking the AbstractViewAction heirarchy as UITypes.  Could probably replace those with a single package annotation.