Yuya Nishihara committed 909c9cf

repoview: fix unicode handling of error message at goto(rev) (fixes #1822)

- 'rev' may be arbitrary non-ascii string
- fromunicode(str(e)) is a typo of tounicode(...)

Comments (0)

Files changed (1)


             rev = self.repo.changectx(rev).rev()
         except error.RepoError:
-            self.showMessage.emit(_("Can't find revision '%s'") % rev)
+            self.showMessage.emit(_("Can't find revision '%s'")
+                                  % hglib.tounicode(str(rev)))
         except LookupError, e:
-            self.showMessage.emit(hglib.fromunicode(str(e)))
+            self.showMessage.emit(hglib.tounicode(str(e)))
             idx = self.model().indexFromRev(rev)
             if idx is not None:
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.