1. Dave Abrahams
  2. pip-misc

Commits

Dave Abrahams  committed 0118382

Remove a few false error expectations.

These should really be handled systematically. In particular, if
expect_error is True and no error occurs, an assertion should fire.
That will reveal all such instances very quickly.

  • Participants
  • Parent commits f6bf7c7
  • Branches default

Comments (0)

Files changed (1)

File tests/test_basic.py

View file
     
     """
     reset_env()
-    result = run_pip('install', '-vvv', 'INITools==0.2', expect_error=True)
+    result = run_pip('install', '-vvv', 'INITools==0.2')
     assert (lib_py + 'site-packages/INITools-0.2-py%s.egg-info' % pyversion) in result.files_created, str(result)
     assert (lib_py + 'site-packages/initools') in result.files_created, sorted(result.files_created.keys())
 
     
     """
     reset_env()
-    result = run_pip('install', '-e', 'svn+http://svn.colorstudy.com/INITools/trunk#egg=initools-dev', expect_error=True)
+    result = run_pip('install', '-e', 'svn+http://svn.colorstudy.com/INITools/trunk#egg=initools-dev')
     egg_link = result.files_created[lib_py + 'site-packages/INITools.egg-link']
     # FIXME: I don't understand why there's a trailing . here:
     assert egg_link.bytes.endswith('/test-scratch/src/initools\n.'), egg_link.bytes
     reset_env()
     mkdir('customdl')
     result = run_pip('install', '-e', 'svn+http://svn.colorstudy.com/INITools/trunk#egg=initools-dev',
-        '--src', 'customsrc', '--download', 'customdl',
-        expect_error=True)
+        '--src', 'customsrc', '--download', 'customdl')
     assert 'customsrc/initools' in result.files_created
     assert 'customsrc/initools/setup.py' in result.files_created
     assert [filename for filename in result.files_created.keys() if filename.startswith('customdl/initools')]