sqrtModPP does not terminate in certain cases

Issue #5 resolved
Former user created an issue

I tried to compute square roots of 1 in prime power moduli using sqrtModPP 1 (p,e) and the computation never terminates. The reason seems to be that sqrtModPP uses sqrtModP 1 p == 1 internally, resulting in a zero result passed to splitOff, which is handled incorrectly. The solution seems to be to use another square root (p-1), which does not result in zeros.

Comments (2)

  1. dafis repo owner

    Thanks. Passing a 0 to splitOff might have also happened in other ways too, so I now test whether that happens, and if it does, don't call splitOff anymore (we've found a root then already).

  2. Log in to comment