- changed status to on hold
Sticky comments lose their sticky status on editing
They become a comment of the system that was being viewed when they were edited, causing several of ours to become lost.
Comments (5)
-
-
- changed status to open
-
This was kind of a pain in the ass to track down, but the problem is that when you save(edit) a comment, you are sending the current systemID, which then updates the comment.SystemID to be accurate instead of 0.
This could be fixed in several ways:
1) you can refactor the comments.php to include an update function instead of a using the save function for both create and update. an update function would only allow changes to the text and not the system ID.
2) Currently, on line 4648 of core.js, we could verify that the comment.commentSticky.active = true, in which case we could submit systemID = 0 instead of the accurate systemID.
-
repo owner I like
#2@thisiswill thank you very much for researching this.. made it 10x easier!
-
repo owner - changed status to resolved
Coming out with next release
- Log in to comment
Good shout, marking as on hold for now and this can be looked at when we get a chance