DisplayEX Default Settings Revert Back After Sync

Issue #91 resolved
Tokyo Panda created an issue
  • What version of CaVE? (Include the file Modified date of the exe for Alpha)
    CaVE v1.5.0.1 | Friday, September 22, 2023, 6:56:22 AM
  • What Locale of Windows/NSO or is selected in CaVE?
    English
  • What version of the NSO app is installed? (Platform and version number)
    SNES NSO | v3.7.0
  • Do you have mods installed, and if so what?
    Official Gamepad Theme (USA) v3.6.0.0
    Full Unlock v3.5.0.0
    DisplayEX v3.7.0.0
  • How exactly can this issue be reproduced so others can do so in order to understand what is broken.
    Open up the NSO app and disable “Fit To Screen” option and select your desired background. Sync your database with CaVE and relaunch the NSO app. All options you may have selected or de-selected will be reverted back to default options. (Ex. Fit To Screen will be re-enabled and the background you picked will not be selected).

Comments (6)

  1. Dark Akuma
    • changed status to open

    Re-posting what I said in discord, just so I know where to start when I get to this.

    i bet I know why too... its because all mod options get erased from the system-save when cave loads it... because cave has to know what specific settings exist in the system save to access them. i have not, and would not program cave to expect options that are specific to mods. so ill have to figure out how to handle that. it will either be rewritting the system-save loading code to be more dynamic, or having mods specify param names/types that they add to the system-save.json.

  2. Dark Akuma

    Ok. Tried to address this issue with a re-write of the system-save.json management code. It SHOULD now load and save non-known parameters.

    While I tried to make this change in a way that makes it plug right into the code that used the old way… other things might be broken because the conversion for them is incorrect. I only did some basic testing that checked out.

    Try this exe.

    https://www.dropbox.com/scl/fi/gbprjqobnagxqtn28iafs/CaVE.exe?rlkey=getbbdyvjuznm56l2qapofoso&dl=1

  3. Tokyo Panda reporter

    From Discord:

    That seems to have done the trick! Checked my settings in NSO, Synced with CaVE and it kept my selections. "Fit to screen" disabled and my selected background. Synced twice and it kept my selection

  4. Log in to comment