Ability to be on a team with an opponent's role/weapons/skin

[Andrew Theel]

This is an exploit someone discovered that allows you to be on Allies, but as an Axis role. You look like the role, have the role's weapons, etc. But you are considered an Allied player. This was just discovered recently and hasn't been abused much, afaik.

To reproduce:

1. Join a team / select role / continue (this will be the role you end up with)
2. Join spectate
3. Wait for the team to have too many players (ratio / unbalanced teams)
4. Attempt to join it
5. It should fail and put you on the other team
6. If you have the role menu open, just close, and it should spawn you as the original role, but on the opposite team.

This is likely still a bug with the new deploy menu and it should be easily fixed.

[Andrew Theel]

Okay this bug did exist in my new deploy menu/system, but I've fixed it. I prevented the server from putting the player on the opposite team if it fails, but for some reason that didn't fix the problem as once they'd join the the other team it'd still happen. So I had to put in a thing that resets the player's current role and weapons when switching teams. I've left the first part in as it's more intuitive to the player. Example: Failed to join team "Wait why am I on a team if it failed?" "This isn't the team I wanted!"

[Andrew Theel]

Fixed in 804bf85

[Andrew Theel]

This issue needs retested and confirmed

[Andrew Theel]

Fixed again in ac7dd4e (hopefully the final working fix)