Tank commanders are able to be killed with small arms fire in turreted vehicles

[Colin Basnett]

No description provided.

[Matt Hands]

Fixed in commit c541f20.

[Colin Basnett]

Re-opening, this is still happening on the build at r496 on the test branch.

[Andrew Theel]

@MattUK somehow the ! wasn't enough, maybe other places need it? Or it somehow got reverted.

[Matt Hands]

Yes, need to check 100% that the test server has a code file with that fix. The bug seemed such an obvious cause & solution that I assumed that was a likely explanation. Spoke briefly with Basnett earlier though & he believes the test branch/server included my fix commit.

If the code change is in place & still have the problem then I have an idea what may be causing it, which is worth checking out. I can't see how it can be the usual player hit detection/damage caused by bullet's ProcessTouch() detecting hit on commander's collision box & head/torso hit points (HitDriver/HitDriverArea), triggering TakeDamage() on the 'Driver'. But I wonder if the bullet is managing to trigger the random crew kill chance in the vehicle's TakeDamage(). If I enable debugging screen messages, that will be easy to test.

What would be great is if we could get bots working again. I used to use them to test this stuff, so they can be really useful in development. Or - and this is probably easier - if we can get it so human players can again deploy on maps with the old deploy system. If we can do that, there's one block of code that can be added back that got bots deploying under the old deploy system.

[Andrew Theel]

I added a console command for you to spawn bots. DebugSpawnBots false, will spawn friendly bots on your location, true for enemies also.

I'm tired of debugging both spawning systems, so old spawning system is basically deprecated at this point, levels need to be setup for new system. I also don't want to support the old system so we have actually have some consistency in this game. Doing this will weed out shit levels that aren't worth the time to convert. So, I won't be adding code support for old spawning system and would prefer not to have it.

I hope this command helps you debug this issue. If not you might consider leaving body command while not exposed and exposed in the commander spot.

[Matt Hands]

Fixed in commit 01a9e31.

Turns out I made 2 typos in the same damned line ! Brackets (or lack of) changing the meaning of the line. Doh ! And sorry gents. :(