Occasionally, player carrying non-resuppliable weapon displays resupply/reload messages under their name

[Matt Hands]

Specific circumstances were player carrying M1 carbine, with bazooka on back, displaying reload/resupply messages to another net player, which would only be relevant if the bazooka were carried.

Believe it was only when the other net player first received the viewed player & their weaponry through replication.

Either (1) new player is not receiving the necessary replicated variables that flag resupply/reload or (2) the variables or precedent variables were not being updated correctly on weapon switch etc.

[Colin Basnett]

It doesn't appear to have anything to do with initial replication, I watched this bug manifest on an anti-tank guy right infront of me. Not sure what causes the bug still, but I'm guessing it's option (2).

[Matt Hands]

I have since been unable to reproduce this bug. So any extra information as to when it occurs and under what exact circumstances would be really helpful. Even confirmation that it still exists would be valuable.

I agree it doesn't seem to be replication. The way the resupply/reload system works is that the relevant bools are in DHPawn, are only ever set on the server and are replicated to any net client that has that DHPawn. Except the net owner, which makes sense, because the player themselves doesn't need to be told that they need resupplying/reloading. The bools are used by other players' HUDs to detect that a player in the sights needs resupply or reload. Even if a new player joins the server, as soon as the DHPawn becomes net relevant to them and they receive the actor through replication, the 2 bools will be replicated with the receives DHPawn actor.

I've checked through all the code in both the weapon classes and DHHud and I don't see any flaws in the logic or any gaps. And, like I said, I can't recreate this now. So I'm wondering if subsequent changes in the HUD or weapon classes have fixed this. Don't recall changes in weapons, although this was noticed & logged 7 weeks ago, but I think the DrawPlayerNames() function in the HUD has been altered since.

Any info very welcome. Cheers.

[Colin Basnett]

This is happening a lot in testing. Increased the severity to major.

[Andrew Theel]

We have yet to find a way to make this reoccur, however lets not put on hold until we do not notice it in a few tests.

[Colin Basnett]

I believe this is fixed, I've not seen this occur in months.