Infantry binocular overlay vastly different from vehicle binocular overlay

[Colin Basnett]

Almost not worth mentioning because I've never noticed this until now! Note also the the magnification levels are different as well.

[Andrew Theel]

I think we should use the left one, which I believe is the Infantry one.

[Matt Hands]

I noticed this when I was adding binocs to exposed vehicle MGs and also making it so you had to actually be carrying binocs to use them in a vehicle binocs position. I left it as it wasn't critical and isn't as straightforward as it seems.

Infantry binocs use RO's 'Weapon_overlays.Scopes.BINOC_overlay' for the overlay texture - for both teams. PlayerFOVZoom=10 seems to be what sets the FOV. I hadn't noticed that was different to the vehicle binocs FOV, which is 12. So an easy alignment is to make the infantry binocs FOV 12.

In vehicles it gets a little more complicated. Allies use 'DH_VehicleOptics_tex.Allied.BINOC_overlay_7x50Allied', which look more like the RO infantry binocs, but without the markings. Germans use 'DH_VehicleOptics_tex.German.BINOC_overlay_6x30Germ', which is a more compressed binocs shape and with more detailed ranging markings. FOV is always 12.

I think Basnett's screenshots were taken on a widescreen, high res setting. I use the same and so do most players, I'd guess. But the 2 shots I've added (marked non-widescreen) show the German and allies vehicle binocs in a 4:3 aspect ratio (1280 x 960). Compare the German ones to 2015-09-23_00003.jpg. This is showing how the binocs functionality isn't handling the screen size/ratio properly and we aren't seeing binocs how they are supposed to look.

So I think:

1. Change infantry binocs to FOV 12.
2. Make vehicle binocs handle screen size/ration properly, scaling the binocs overlay accordingly so it looks like my pics.
3. Ditch the RO infantry 'universal team' binocs, on the assumption that DH devs have added more accurate German/Allies specific overlays.
4. Use the vehicle binocs overlays for the infantry binocs.

I think no.4 means adding German and Allies versions of the infantry binocs inventory item. And then change all the role classes to use one or the other. It would be easy to have the binocs set their overlay based on the user's team, but then we would get the situation where an Allied player picks up binocs dropped by a German and sees allied binoc markings.

[Matt Hands]

1. Matched infantry binocs FOV to vehicle binocs (FOV 12) in commit 7deb714,

[Matt Hands]

I've marked this as on hold, for a future release, because:

• it isn't a simple change as probably first appeared (see above)
• it's trivial
• there are much more important things to fix/add/improve.