Third-person reload animation does not play when reloading empty sniper rifles

[Colin Basnett]

https://www.youtube.com/watch?v=zYzx2hVh9ig&feature=youtu.be

[Colin Basnett]

Figured out the cause of this one.

The offending lines are in ROPawn.uc @ 1921:

            if (WeaponAttachment.bOutOfAmmo)
            {
                if (bIsCrawling)
                    PlayerAnim = WeaponAttachment.PA_ProneReloadEmptyAnim;
                else
                    PlayerAnim = WeaponAttachment.PA_ReloadEmptyAnim;
            }
            else
            {
                if (bIsCrawling)
                    PlayerAnim = WeaponAttachment.PA_ProneReloadAnim;
                else
                    PlayerAnim = WeaponAttachment.PA_ReloadAnim;
            }

Essentially, since the weapon attachment is bOutOfAmmo, it will attempt to play an animation that it doesn't have instead of looping the single reload animation. One quick and dirty option is to just never set bOutOfAmmo to true, but this may have knock-on effects. Will investigate.

[Colin Basnett]

Fix was easier than expected, just needed to set PA_ProneReloadEmptyAnim and PA_ReloadEmptyAnim. Fixed in commit ac73778.