Commits

Show all
Author Commit Message Labels Comments Date
Dave Cheney
cmd/5g: avoid temporary in cgen_shift func shift(a int) int { a <<= 2 return a } --- prog list "shift" --- 0000 (/home/dfc/src/shift.go:3) TEXT shift+0(SB),$0-8 0001 (/home/dfc/src/shift.go:4) MOVW $2,R0 0002 (/home/dfc/src/shift.go:4) MOVW a+0(FP),R1 0003 (/home/dfc/src/shift.go:4) TST R0, 0004 (/home/dfc/src/shift.go:4) BEQ ,9(APC) 0005 (/home/dfc/src/shift.go:4) MOVW $32,R3 0006 (/home/dfc/src/s…
Dave Cheney
cmd/5g: avoid temporaries for consant lengths in agen OINDEX
Dave Cheney
Backed out changeset 97a686a159b9
Dave Cheney
cmd/5g: avoid temporary in cgenindex pando(~/go/src/pkg/fmt) % ~/go/misc/benchcmp {old,new}.txt benchmark old ns/op new ns/op delta BenchmarkSprintfEmpty 749 749 +0.00% BenchmarkSprintfString 3033 3010 -0.76% BenchmarkSprintfInt 2435 2350 -3.49% BenchmarkSprintfIntInt 3442 3373 -2.00% BenchmarkSprintfPrefixedIn…
Dave Cheney
merge from tip
Dave Cheney
cmd/5g: avoid temporary in slice bounds check before func addr(s[]int) *int { return &s[2] 10c1c: e28d0008 add r0, sp, #8 10c20: e5901004 ldr r1, [r0, #4] 10c24: e3a02002 mov r2, #2 10c28: e1510002 cmp r1, r2 10c2c: 8a000000 bhi 10c34 <main.addr+0x34> 10c30: eb0035e6 bl 1e3d0 <runtime.panicindex> 10c34: e5…
Nigel Tao
image/jpeg: move the level-shift and clip out of the idct function, to be consistent with the fdct function, and to ease any future idct rewrites in assembly. The BenchmarkIDCT delta is obviously just an accounting change and not a real saving, but it does give an indication of what proportion of time was spent in the actual IDCT and what proportion was in shift and clip. The idct time taken is now comparable to fdct. The BenchmarkFDCT delta is an estimate of benchmark noise. benchmark old ns/op new ns/op delta BenchmarkFDCT …
Nigel Tao
image/jpeg: clean up BenchmarkDecode and BenchmarkEncode to not refer to opacity. Those references were copy/pasted from the image/png encoding benchmarks, which cares whether or not the source image is opaque, but the JPEG encoder does not care. R=r CC=golang-dev http://codereview.appspot.com/6623052
Robert Hencke
doc/debugging_with_gdb: fix minor typo (space before comma) R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6610061 Committer: Rob Pike <r@golang.org>
Nigel Tao
image/jpeg: add DCT tests, do a small optimization (common sub-expression elimination) in idct.go. benchmark old ns/op new ns/op delta BenchmarkIDCT 5649 5610 -0.69% BenchmarkDecodeRGBOpaque 2948607 2941051 -0.26% The "type block" declaration moved so that idct.go is compilable as a stand-alone file: "go tool 6g -S idct.go" works. R=r CC=golang-dev http://codereview.appspot.com/6619056
Rémy Oudompheng
cmd/gc: avoid clobbering the AST in cgen_callmeth. It confused the detection of init loops when involving method calls. Fixes issue 3890. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6620067
Rémy Oudompheng
cmd/6g: fix out of registers when chaining integer divisions. Fixes issue 4201. R=golang-dev, rsc CC=golang-dev, remy http://codereview.appspot.com/6622055
Rémy Oudompheng
cmd/gc: make rnd() more 64-bit-friendly. Fixes issue 4200. R=golang-dev, dave, rsc CC=golang-dev http://codereview.appspot.com/6619057
Rob Pike
text/template: fix nil crash on Templates Fixes issue 3872. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6612060
Rob Pike
text/template: add an unexported method to Node Protects the package a little against undesirable clients. R=golang-dev, bradfitz, rsc CC=golang-dev http://codereview.appspot.com/6624054
Dave Cheney
Dave Cheney
Merge from trunk
Dave Cheney
cmd/5g: avoid temporary during constant asop func add() int { var a int a += 10 a += 20 a += 30 a -= 10 a -= 20 a -= 30 return a } before --- prog list "add" --- 0000 (/home/dfc/src/add.go:5) TEXT add+0(SB),$0-4 0001 (/home/dfc/src/add.go:6) MOVW $0,R2 0002 (/home/dfc/src/add.go:7) MOVW $10,R0 0003 (/home/dfc/src/add.go:7) ADD R0,R2,R1 0004 (/home/dfc/src/…
Rémy Oudompheng
runtime: fix a panic when growing zero-width-element slices. Fixes issue 4197. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6611056
Dmitriy Vyukov
pprof: add goroutine blocking profiling The profiler collects goroutine blocking information similar to Google Perf Tools. You may see an example of the profile (converted to svg) attached to http://code.google.com/p/go/issues/detail?id=3946 The public API changes are: +pkg runtime, func BlockProfile([]BlockProfileRecord) (int, bool) +pkg runtime, func SetBlockProfileRate(int) +pkg runtime, method (*BlockProfileRecord) Stack() []uintptr +pkg runtime, type BlockProfileRecord struct +pkg runtime, type BlockProfileRecord struct, Count int64 +pkg runtime, type BlockProfileRecord struct, Cycles int64 +pkg runtime, type BlockProfileRecord struct, embedded StackRecord R=rsc, dave, minux.ma, r CC=gobot, golang-dev, r, remyoudompheng http://codereview.appspot.com/6443115
Daniel Morsing
test: Add rundir, rundircmpout and errorcheckdir commands to testlib and run.go rundir will compile each file in the directory in lexicographic order, link the last file as the main package and run the resulting program. rundircmpout is an related command, that will compare the output of the program to an corresponding .out file errorcheckdir will compile each file in a directory in lexicographic order, running errorcheck on each file as it compiles. All compilations are ass…
Jan Ziak
cmd/cc: map C int to int32 in Go defs R=golang-dev, minux.ma, rsc CC=golang-dev http://codereview.appspot.com/6621052 Committer: Shenghou Ma <minux.ma@gmail.com>
Dave Cheney
merge from tip
Dave Cheney
cmd/5g: avoid temporary during constant OINDEX func addr(s[]int) *int { return &s[2] } --- prog list "addr" --- 0000 (/home/dfc/src/addr.go:5) TEXT addr+0(SB),$0-16 0001 (/home/dfc/src/addr.go:6) MOVW $s+0(FP),R0 0002 (/home/dfc/src/addr.go:6) MOVW 4(R0),R1 0003 (/home/dfc/src/addr.go:6) MOVW $2,R2 0004 (/home/dfc/src/addr.go:6) CMP R2,R1, 0005 (/home/dfc/src/addr.go:6) BHI ,7(APC) 0006 (/home/dfc/src/addr.go:6) BL …
Rémy Oudompheng
cmd/5g: fix out of registers in nested calls, add compiler torture test. R=golang-dev, dave, daniel.morsing, rsc CC=golang-dev, remy http://codereview.appspot.com/6586072
Dmitry Chestnykh
crypto/sha256, crypto/sha512: 1.3x speedup SHA-256: benchmark old ns/op new ns/op delta BenchmarkHash1K 21686 16912 -22.01% BenchmarkHash8K 173216 135020 -22.05% benchmark old MB/s new MB/s speedup BenchmarkHash1K 47.22 60.55 1.28x BenchmarkHash8K 47.29 60.67 1.28x SHA-512: benchmark old ns/op new ns/op delta BenchmarkHash1K …
Akshat Kumar
runtime: mask SSE exceptions on plan9/amd64 The Go run-time assumes that all SSE floating-point exceptions are masked so that Go programs are not broken by such invalid operations. By default, the 64-bit version of the Plan 9 kernel masks only some SSE floating-point exceptions. Here, we mask them all on a per-thread basis. R=rsc, rminnich, minux.ma CC=golang-dev http://codereview.appspot.com/6592056 Committer: Russ Cox <rsc@golang.org>
minux
doc/codewalk: make it work with jQuery 1.8.2 so that it could work with the bundled jQuery. R=adg CC=golang-dev http://codereview.appspot.com/6592073
Robert Griesemer
go/printer: don't forget the .0 in 1.0 (use floating-point rather then integer constant division) gofmt -w src misc Fixes issue 3965. R=r, bsiegert, 0xjnml CC=bradfitz, golang-dev http://codereview.appspot.com/6610051
Robert Griesemer
go/printer: parenthesize literal function types in conversions Also: gofmt -w src misc R=r CC=golang-dev, iant http://codereview.appspot.com/6591071
  1. Prev
  2. Next