Commits

Show all
Author Commit Message Labels Comments Date
Andrew Gerrand
weekly.2011-11-01 R=rsc, r CC=golang-dev http://codereview.appspot.com/5336044
Tags
weekly.2011-11-01
Andrew Balholm
html: stop at scope marker node when generating implied </a> tags A <a> tag generates implied end tags for any open <a> elements. But it shouldn't do that when it is inside a table cell the the open <a> is outside the table. So stop the search for an open <a> when we reach a scope marker node. Pass tests1.dat, test 78: <a href="blah">aba<table><tr><td><a href="foo">br</td></tr>x</table>aoe | <html> | <head> | <body> | <a> | href="blah" | "a…
Nigel Tao
html: refactor the blacklist for the "render and re-parse" test. R=andybalholm CC=golang-dev, mikesamuel http://codereview.appspot.com/5331056
msolo
textproto: prevent long lines in HTTP headers from causing HTTP 400 responses. This fixes the issue without an extra copy in the average case. R=golang-dev, ality, bradfitz CC=golang-dev http://codereview.appspot.com/5272049 Committer: Brad Fitzpatrick <bradfitz@golang.org>
Rob Pike
doc/Makefile: add 'all' rule to build all docs R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5334044
Russ Cox
gc: test + fix escape analysis bug R=lvd CC=golang-dev http://codereview.appspot.com/5333049
Andrew Gerrand
doc: refer to tour.golang.org instead of go-tour.appspot.com R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5331055
Charles L. Dorian
doc: fix typo in spec example code comment R=r, golang-dev, adg CC=golang-dev http://codereview.appspot.com/5308071 Committer: Andrew Gerrand <adg@golang.org>
Robert Griesemer
go spec: introduce rune type R=r, iant, rsc, r CC=golang-dev http://codereview.appspot.com/5293048 Committer: Russ Cox <rsc@golang.org>
Russ Cox
rpc: avoid infinite loop on input error Fixes issue 1828. Fixes issue 2179. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5305084
Russ Cox
gopack: change archive file name length back to 16 This CL grew the archive file name length from 16 to 64: changeset: 909:58574851d792 user: Russ Cox <rsc@golang.org> date: Mon Oct 20 13:53:56 2008 -0700 Back then, every x.go file in a package became an x.6 file in the archive. It was important to be able to allow the use of long Go source file names, hence the increase in size. Today, all Go source fil…
Russ Cox
os: do not interpret 0-length read as EOF Fixes issue 2402. R=golang-dev, bradfitz, r CC=golang-dev http://codereview.appspot.com/5298081
Andrew Balholm
html: process </td> tags; foster parent at most one node per token Correctly close table cell when </td> is read. Because of reconstructing the active formatting elements, more than one node may be created when reading a single token. If both nodes are foster parented, they will be siblings, but the first node should be the parent of the second. Pass tests1.dat, test 77: <a href="blah">aba<table><a href="foo">br<tr><td></td></tr>x</table>aoe | <html> | <head…
Scott Lawrence
template: fix error checking on execute without parse Fixed error checking in exec.go to give a sensible error message when execution is attempted before a successful parse (rather than an outright panic). R=r CC=golang-dev http://codereview.appspot.com/5306065 Committer: Rob Pike <r@golang.org>
Russ Cox
pkg: minor cleanup remove some redundant .String() change variable name to make it os.Error-proof R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/5302075
Russ Cox
test: make bug107 os.Error-proof R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5306087
Russ Cox
runtime/pprof: document OS X being broken R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5307078
Scott Lawrence
time: add RFC1123 with numeric timezone format Fixes issue 841. R=rsc, r CC=golang-dev http://codereview.appspot.com/5322058 Committer: Rob Pike <r@golang.org>
Charles L. Dorian
math: Improved accuracy for Sin and Cos. Fixes issue 1564. R=rsc, dchest CC=golang-dev http://codereview.appspot.com/5320056 Committer: Russ Cox <rsc@golang.org>
Alexander Reece
json: Properly handle nil slices. Marshal nil slices as null and parse null value as a nil slice. Fixes issue 2278. R=rsc CC=golang-dev http://codereview.appspot.com/5257053 Committer: Russ Cox <rsc@golang.org>
Russ Cox
A+C: Alexander Reece (individual CLA) R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5297072
Andrey Mirtchovski
syscall: fix Await msg on Plan 9 Plan 9's await() returns '' for nil exit status but programs, most notably gotest, see this as an error return. R=rsc CC=golang-dev http://codereview.appspot.com/5305079 Committer: Russ Cox <rsc@golang.org>
Luuk van Dijk
gc: clean up printing. Got rid of all the magic mystery globals. Now for %N, %T, and %S, the flags +,- and # set a sticky debug, sym and export mode, only visible in the new fmt.c. Default is error mode. Handle h and l flags consistently with the least side effects, so we can now change things without worrying about unrelated things breaking. fixes issue 2361 R=rsc CC=golang-dev http://codereview.appspot.com/5316043
Fazlul Shahriar
net: Plan 9 fixes Makes all tests pass. R=rsc CC=golang-dev http://codereview.appspot.com/5320041 Committer: Russ Cox <rsc@golang.org>
Jan Newmarch
misc/emacs/go-lang.el: Fix restoration of multiple windows in a frame after gofmt If a frame has multiple windows then the windows must all be restored after gofmt has finished and the old windows must be restored. Before this fix, only the Go code edit window would be left. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5280050 Committer: Russ Cox <rsc@golang.org>
Marcel van Lohuizen
exp/norm: fixed bug that creeped in with moving to the new regexp, which caused the last line of a test block to be ignored. R=r, rsc CC=golang-dev http://codereview.appspot.com/5177052
Dave Cheney
exp/ssh: fix length header leaking into channel data streams. The payload of a data message is defined as an SSH string type, which uses the first four bytes to encode its length. When channelData and channelExtendedData were added I defined Payload as []byte to be able to use it directly without a string to []byte conversion. This resulted in the length data leaking into the payload data. This CL fixes the bug, and restores agl's original fast path code. …
Andrew Balholm
html: adjust bookmark in "adoption agency" algorithm In the adoption agency algorithm, the formatting element is sometimes removed from the list of active formatting elements and reinserted at a later index. In that case, the bookmark showing where it is to be reinserted needs to be moved, so that its position relative to its neighbors remains the same (and also so that it doesn't become out of bounds). Pass tests1.dat, test 70: <DIV> abc <B> def <…
Andrew Balholm
html: don't run "adoption agency" on elements that aren't in scope. Pass tests1.dat, test 55: <!DOCTYPE html><font><table></font></table></font> | <!DOCTYPE html> | <html> | <head> | <body> | <font> | <table> Also pass tests through test 69: <DIV> abc <B> def <I> ghi <P> jkl R=nigeltao CC=golang-dev http://codereview.appspot.com/5309074 Committer: Nigel Tao <nigeltao@golang.org>
Russ Cox
fmt: handle os.Error values Handling os.Error is no different than handling fmt.Stringer here, so the code is redundant now, but it will be necessary once error goes in. Adding it now will make gofix fix it. R=r CC=golang-dev http://codereview.appspot.com/5331045
  1. Prev
  2. Next